Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1985] Lazily call version in click params #6812

Closed
stu-k opened this issue Jan 31, 2023 · 0 comments
Closed

[CT-1985] Lazily call version in click params #6812

stu-k opened this issue Jan 31, 2023 · 0 comments
Assignees
Labels

Comments

@stu-k
Copy link
Contributor

stu-k commented Jan 31, 2023

As part of the work in #6802 we use click.version_option, however the eagerly calls dbt.version.get_version_information which in turn calls our legacy flags module. This presents a problem since we want that module to only be loaded after our click group has run. This work should prevent dbt.version.get_version_infromation from being called before the click group as executed. Likely go back to using version as a click.option and use the callback arg.

@github-actions github-actions bot changed the title Lazily call version in click params [CT-1985] Lazily call version in click params Jan 31, 2023
@stu-k stu-k self-assigned this Jan 31, 2023
@stu-k stu-k mentioned this issue Jan 31, 2023
6 tasks
@stu-k stu-k closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant