Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1687] Rename every exception to end in Error #6460

Closed
emmyoop opened this issue Dec 20, 2022 · 0 comments · Fixed by #6539
Closed

[CT-1687] Rename every exception to end in Error #6460

emmyoop opened this issue Dec 20, 2022 · 0 comments · Fixed by #6539
Assignees
@emmyoop
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Milestone
v1.4

Comments

@emmyoop
Copy link
Member

emmyoop commented Dec 20, 2022 •
edited
Loading

Exceptions have been cleaned up, but let's also standardize the naming pattern.

Looks great, but should we rename every exception to end in Error similar to Python's built-in exceptions?

At the very least, we should standardize on using either Error or Exception uniformly everywhere?

Originally posted by @aranke in #6347 (review)
@github-actions github-actions bot changed the title Rename every exception to end in Error [CT-1687] Rename every exception to end in Error Dec 20, 2022
@emmyoop emmyoop added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Dec 20, 2022
@emmyoop emmyoop self-assigned this Jan 6, 2023
@emmyoop emmyoop mentioned this issue Jan 6, 2023
Merged
6 tasks
@jtcohen6 jtcohen6 added this to the v1.4 milestone Jan 11, 2023
@damian3031 damian3031 mentioned this issue Jan 30, 2023
Merged
@kokorin kokorin mentioned this issue Feb 3, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmyoop emmyoop

Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Rename exceptions dbt-labs/dbt-core
2 participants
@emmyoop @jtcohen6