Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1612] Add deprecation decorator for functions #6393

Closed
emmyoop opened this issue Dec 6, 2022 · 2 comments · Fixed by #6540
Closed

[CT-1612] Add deprecation decorator for functions #6393

emmyoop opened this issue Dec 6, 2022 · 2 comments · Fixed by #6540
Assignees
Labels
adapter_plugins Issues relating to third-party adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Dec 6, 2022

Create a decorator that can be added to functions to mark them as deprecated.

Related to #6347 as we need to make the functions that currently trigger exceptions as deprecated for all the adapters that may be using them.

Open questions:

  • What standard info to include with deprecation?
  • When should the exception functions actually be deprecated - 1 or 2 versions?
@emmyoop emmyoop self-assigned this Dec 6, 2022
@github-actions github-actions bot changed the title Add deprecation decorator for functions [CT-1612] Add deprecation decorator for functions Dec 6, 2022
@jtcohen6 jtcohen6 added adapter_plugins Issues relating to third-party adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Dec 6, 2022
@justbldwn
Copy link
Contributor

hi @emmyoop! i see this is self-assigned - are you looking for PR's for this issue? or have you already started work on this? just checking before possibly contributing 👍

@emmyoop
Copy link
Member Author

emmyoop commented Dec 7, 2022

@justbldwn I'll be working on this over our next sprint. Thanks for checking in though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter_plugins Issues relating to third-party adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants