Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1416] [Bug] GitHub Actions: Deprecating save-state and set-output commands #6153

Closed
2 tasks done
kevinneville opened this issue Oct 26, 2022 · 4 comments · Fixed by #6635
Closed
2 tasks done

[CT-1416] [Bug] GitHub Actions: Deprecating save-state and set-output commands #6153

kevinneville opened this issue Oct 26, 2022 · 4 comments · Fixed by #6635
Assignees
@kevinneville
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@kevinneville
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

GitHub Actions: Deprecating save-state and set-output commands, these should be replaced with the proposed solution.
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.

Expected Behavior

We should not see the warnings.

Steps To Reproduce

Run all GH checks.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response
@kevinneville kevinneville added bug Something isn't working triage labels Oct 26, 2022
@github-actions github-actions bot changed the title [Bug] GitHub Actions: Deprecating save-state and set-output commands [CT-1416] [Bug] GitHub Actions: Deprecating save-state and set-output commands Oct 26, 2022
@leahwicz leahwicz added repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed bug Something isn't working triage labels Oct 27, 2022
@leahwicz
Copy link
Contributor

Thanks @kevinneville for the issue!

@emmyoop we can use this for tracking for this repo since I don't see an issue here yet

@leahwicz
Copy link
Contributor

Oh nvm @kevinneville I see your PR already!!!
#6152

@leahwicz leahwicz mentioned this issue Oct 27, 2022
Closed
6 tasks
@kevinneville
Copy link
Contributor Author

Oh nvm @kevinneville I see your PR already!!!

#6152

Sorry, not sure if I missed something in the contribution guide. My first PR, I tried to follow it the best I could.

@leahwicz
Copy link
Contributor

@kevinneville oh no problem!

In the top of the PR description, you will see the "resolve #" line. If you add the issue number there, it links the issue and the PR so its easy to see the 2 are connected. I edited your PR description to have that so the link is there now

@davidbloss davidbloss mentioned this issue Jan 17, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinneville kevinneville

Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update gh action set-output variables dbt-labs/dbt-core
Fix deprecated set-output commands
2 participants
@kevinneville @leahwicz