Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1299] Make selected_resource non-global #6009

Closed
gshank opened this issue Oct 5, 2022 · 2 comments
Closed

[CT-1299] Make selected_resource non-global #6009

gshank opened this issue Oct 5, 2022 · 2 comments
Labels
python_api Issues related to dbtRunner Python entry point stale Issues that have gone stale

Comments

@gshank
Copy link
Contributor

gshank commented Oct 5, 2022

Copied from #5088, which we are closing in favor of this because we're not actually seeing the test failure now.

Having a whole separate file for a global selected_resources variable in core/dbt/selected_resource.py is kind of overkill. It should be in some other file. In addition we should try hard to implement it in a way that doesn't use a global file variable, because they are a bad idea in general (despite the fact that we have a number of them) and they all need to be reset for tests to run properly (and quite possibly any persistent server code).

@github-actions github-actions bot changed the title Make selected_resource non-global [CT-1299] Make selected_resource non-global Oct 5, 2022
@jtcohen6 jtcohen6 added python_api Issues related to dbtRunner Python entry point Team:Execution labels Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jun 5, 2023
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python_api Issues related to dbtRunner Python entry point stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

2 participants