Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1191] Memory growth: stop saving Exceptions in logging events #5848

Closed
gshank opened this issue Sep 15, 2022 · 0 comments · Fixed by #5858
Closed

[CT-1191] Memory growth: stop saving Exceptions in logging events #5848

gshank opened this issue Sep 15, 2022 · 0 comments · Fixed by #5858
Assignees
Labels
logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Milestone

Comments

@gshank
Copy link
Contributor

gshank commented Sep 15, 2022

Memory in a long-running server was continually growing because when an error occurred the node was saved in an Exception which was saved in a logging event which was stored in the logging event history. The references to the nodes meant that old manifests could not be garbage collected.

We should change Exceptions in logging events to strings, and add 'event_buffer_size' to UserConfig.

@github-actions github-actions bot changed the title Memory growth: stop saving Exceptions in logging events [CT-1191] Memory growth: stop saving Exceptions in logging events Sep 15, 2022
@gshank gshank self-assigned this Sep 15, 2022
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality Team:Language logging labels Sep 19, 2022
@jtcohen6 jtcohen6 added this to the v1.3 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants