add a base python job helper class #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
requested review from
nathaniel-may,
gshank and
colin-rogers-dbt
and removed request for
a team and
nathaniel-may
gshank
approved these changes
Sep 9, 2022
ChenyuLInx
force-pushed
the
enhancement/python_submission_helper
branch
from
3024344
to
451e7db
Compare
4 tasks
josephberni
pushed a commit
to Gousto/dbt-core
that referenced
this pull request
Sep 16, 2022
* add a base python job helper class * fix comment, add changelog * fix quote for adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor for dbt-labs/dbt-bigquery#248
Description
Add PythonJobHelper base class in dbt core, move common logic to core. Also added mypy check
Checklist
changie newto create a changelog entry