Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1106] [Bug] Include py.typed in MANIFEST.in #5737

Closed
2 tasks done
panasenco opened this issue Aug 30, 2022 · 1 comment · Fixed by #5703
Closed
2 tasks done

[CT-1106] [Bug] Include py.typed in MANIFEST.in #5737

panasenco opened this issue Aug 30, 2022 · 1 comment · Fixed by #5703
Labels
bug Something isn't working help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors

Comments

@panasenco
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Currently when developing a dbt adapter and installing dbt-core with pip, I get errors like the following when trying to run mypy:

error: Skipping analyzing "dbt.contracts.connection": module is installed, but missing library stubs or py.typed marker
error: Skipping analyzing "dbt.events": module is installed, but missing library stubs or py.typed marker

This is because the file py.typed is not included in the package uploaded to pypi.

Expected Behavior

No mypy errors when checking types of packages that depend on dbt-core

Steps To Reproduce

Create a file with the line import dbt.events
Run mypy on that file

Relevant log output

No response

Environment

- OS: Ubuntu
- Python: 3.10.4
- dbt: 1.1.1

Which database adapter are you using with dbt?

other (mention it in "Additional Context")

Additional Context

Writing a custom adapter for dbt

@panasenco panasenco added bug Something isn't working triage labels Aug 30, 2022
@github-actions github-actions bot changed the title [Bug] Include py.typed in MANIFEST.in [CT-1106] [Bug] Include py.typed in MANIFEST.in Aug 30, 2022
@dbeatty10 dbeatty10 self-assigned this Aug 31, 2022
@dbeatty10
Copy link
Contributor

Exciting that you are working on a custom database adapter @panasenco!

(Side note: you might find a bunch of helpful experts in the #adapter-ecosystem Slack channel if you aren't already subscribed there.)

Thanks for submitting this issue and the relevant pull request 👍

@dbeatty10 dbeatty10 removed the triage label Aug 31, 2022
@dbeatty10 dbeatty10 removed their assignment Aug 31, 2022
@leahwicz leahwicz added the help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants