You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues, and I could not find an existing issue for this feature
I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion
Describe the feature
The metrics package is looking to expand the types of metrics that it can operate on and one consistent piece of feedback we've received is that people want to be able to define metrics that have a concept of time included in their definition. IE 14 Day Average, etc.
This functionality has an open PR here for the metrics package. We've proven that it works but want to move the definition of this metric aspect into the metric itself instead of meta.
Example:
metrics:
- name: base_lookback_metricmodel: ref('fact_orders')label: Total Discount ($)timestamp: order_datetime_grains: [day, week, month]type: sumsql: discount_totaldimensions:
- had_discount
- order_countrywindow: 14 days
Describe alternatives you've considered
Not including it.
Who will this benefit?
Anyone who wants to use metrics that are cumulative or lookback.
Are you interested in contributing this feature?
Yep!
Anything else?
I am not married or even really attached to the name of lookback. It is a placeholder while we work on the functionality.
The text was updated successfully, but these errors were encountered:
Thanks for the issue and the PR @callum-mcdata! Adding support for rolling lookback windows is cool and good. Let's add this into the v1.3 initiative around improvements to metrics.
Very open to suggestions from the world (or just @dbeatty10) about what we'll want to call this thing. I don't mind lookback personally.
Some of these might be able to be dismissed quickly.
window is probably my favorite so far. Not because I've spent a sufficient amount of time understanding the context though! 😅 Mainly because after some brief googling, learned that window is the only required parameter of Series.rolling() within Pandas (which return Rolling objects that support a variety of aggregation functions). Learn more here.
Is this your first time submitting a feature request?
Describe the feature
The metrics package is looking to expand the types of metrics that it can operate on and one consistent piece of feedback we've received is that people want to be able to define metrics that have a concept of time included in their definition. IE 14 Day Average, etc.
This functionality has an open PR here for the metrics package. We've proven that it works but want to move the definition of this metric aspect into the metric itself instead of meta.
Example:
Describe alternatives you've considered
Not including it.
Who will this benefit?
Anyone who wants to use metrics that are cumulative or lookback.
Are you interested in contributing this feature?
Yep!
Anything else?
I am not married or even really attached to the name of lookback. It is a placeholder while we work on the functionality.
The text was updated successfully, but these errors were encountered: