Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-727] Hide Package Names from Documentation #5333

Closed
1 task done
taylorterwin opened this issue Jun 6, 2022 · 10 comments
Closed
1 task done

[CT-727] Hide Package Names from Documentation #5333

taylorterwin opened this issue Jun 6, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@taylorterwin
Copy link

Is this your first time opening an issue?

Describe the Feature

We can disable individual models in main project but we can't do the same for an entire imported dbt package. (https://docs.getdbt.com/reference/resource-properties/docs)

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@taylorterwin taylorterwin added enhancement New feature or request triage labels Jun 6, 2022
@github-actions github-actions bot changed the title Hide Package Names from Documentation [CT-727] Hide Package Names from Documentation Jun 6, 2022
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 6, 2022

@taylorterwin Thanks for opening!

I understand the ask here to be: Turn docs into a real node config, which can be set for multiple resources at once in dbt_project.yml, in addition to one-by-one in other project .yml files.

# dbt_project.yml
models:
  installed_package:
    # hide all models from this package in the docs
    +docs:
      show: false

I super agree! It would help with cool things like this, too: dbt-labs/dbt-docs#275

The code paths here can be a bit tricky. If there's a community member who feels interested and motivated, we might be able to support an external contribution for this.

@leahwicz
Copy link
Contributor

leahwicz commented Jun 14, 2022

AC: Turn docs into a real node config, with backwards compatibility for people (e.g. dbt-docs) who are accessing it as a top-level attribute (node.docs) in manifest.json

@matt-winkler
Copy link
Contributor

matt-winkler commented Jun 17, 2022

Hey @leahwicz curious: To make this backwards compatible, we'd basically maintain the existing code which maps docs properties into their own component of the manifest.json, correct? Are there other gotchas we'd need to think about in terms of overrides / collisions between that and a docs property that lives under config?

cc @b-per and @sungchun12

@grahamcarman
Copy link

grahamcarman commented Aug 3, 2022

Just saw that #5397 was just merged! Is there still work to be done, though, to enable show: false at the dbt_project.yml level?

@b-per
Copy link
Contributor

b-per commented Aug 4, 2022

Even if it got merged to main it is not available to any stable release yet. I believe it will make its way to some 1.3 beta and will be in the final release of dbt 1.3 (planned for Oct if I'm correct)

@jtcohen6
Copy link
Contributor

jtcohen6 commented Aug 4, 2022

Going to close this as resolved! Will be included in the next v1.3 beta prerelease

@jtcohen6 jtcohen6 closed this as completed Aug 4, 2022
@mkleinbort-ic
Copy link

I'm trying to use this feature, but the nodes are still appearing in my DAG by default. Is there any way to turn off specific tags or sources by default? Ie. on opening the documentation's dag the filter is excluding them.

@b-per
Copy link
Contributor

b-per commented Nov 2, 2022

Hi! docs: {show: false} is hiding individual pages for the nodes but they will still appear on the docs site in the DAG ,in another grey color, without the ability to "drill into" them.

Today it is not possible to hide nodes from the docs site DAG

@G14rb
Copy link

G14rb commented Nov 15, 2022

Hi! Sorry for the stupid and articulate question, does it mean that the "docs show" will be grey, so still visible on DAG? Correct me if I'm wrong, in this case I could exclude them but in the DAG I won't see any lineage before and after. I mean it's not possible at this stage to go from A -> B -> C and visualize just A -> C using {show: false}. Thanks

@b-per
Copy link
Contributor

b-per commented Nov 15, 2022

Yes, show: false will still show in the DAG, greyed out, without the ability to drill into the docs of the hidden model.

Today the dbt docs don't support removing models from the lineage entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants