Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Better incremental test with full-expect #10321

Closed
3 tasks done
DamienBoue opened this issue Jun 17, 2024 · 1 comment
Closed
3 tasks done

[Feature] Better incremental test with full-expect #10321

DamienBoue opened this issue Jun 17, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request unit tests Issues related to built-in dbt unit testing functionality

Comments

@DamienBoue
Copy link

DamienBoue commented Jun 17, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

When we use incremental tests we are not able to test if the merge happen correctly.

Ex:

  • I have 2 elements already calculated, A and B
  • I need to add one element C and to modify the old element A
  • I want to test that my incremental test has only 3 elements, A B and C, with B that has been modified and not duplicated

One solution would be to let us test a full-expect that can test the integrality of the data present after the increment.

This could be written as follow:

expect:
  full_mode: true
  rows:
    - { all the rows }

This would permit us to have non regression test on which someone break the unique key where the merge is done.

Describe alternatives you've considered

No response

Who will this benefit?

Everyone who intent to make non regression tests in the application

Are you interested in contributing this feature?

No response

Anything else?

No response

@DamienBoue DamienBoue added enhancement New feature or request triage labels Jun 17, 2024
@DamienBoue DamienBoue changed the title [Feature] Better incremental test [Feature] Better incremental test with full-expect Jun 17, 2024
@dbeatty10 dbeatty10 added the unit tests Issues related to built-in dbt unit testing functionality label Jun 25, 2024
@dbeatty10
Copy link
Contributor

Thanks for reaching out @DamienBoue !

This type of functionality for incremental models is already on our radar in #8664, and I'm going to close this one as a duplicate. That one is currently blocked on #8499.

If you have any ideas or feedback, we'd welcome your participation in #8664.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@dbeatty10 dbeatty10 added duplicate This issue or pull request already exists and removed triage labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request unit tests Issues related to built-in dbt unit testing functionality
Projects
None yet
Development

No branches or pull requests

2 participants