Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject TagIterator Into BlockIterator #38

Closed
1 task done
peterallenwebb opened this issue Jan 23, 2024 · 0 comments · Fixed by #39
Closed
1 task done

Inject TagIterator Into BlockIterator #38

peterallenwebb opened this issue Jan 23, 2024 · 0 comments · Fixed by #39

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Jan 23, 2024 •
edited
Loading

Housekeeping

  • I am a maintainer of dbt-common

Short description

For greater flexibility, we need to inject the instance of TagIterator used for parsing into BlockIterator upon construction.

Acceptance criteria

The 'data' parameter for BlockIterator has been replaced by a TagIterator instance.

Suggested Tests

Existing tests will suffice.

Impact to Other Teams

None

Will backports be required?

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inject TagIterator into BlockIterator dbt-labs/dbt-common
1 participant
@peterallenwebb