Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CatalogKey, ColumnMetadata, ColumnMap, CatalogTable to dbt-common #147

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Jun 3, 2024

Description

As per internal Slack conversation, we want to move the catalog artifact schema to dbt-common so adapters can depend on them (PR 1, PR 2).

This PR moves the following to dbt-common: CatalogKey, ColumnMetadata, ColumnMap, CatalogTable
Draft PR in dbt-core that keeps imports intact but uses code from dbt-common is here: dbt-labs/dbt-core#10253

Checklist

@cla-bot cla-bot bot added the cla:yes label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke requested a review from MichelleArk June 3, 2024 10:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 64.04%. Comparing base (ddb28aa) to head (18fb414).

Files Patch % Lines
dbt_common/contracts/metadata.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   64.39%   64.04%   -0.35%     
==========================================
  Files          51       51              
  Lines        3134     3151      +17     
==========================================
  Hits         2018     2018              
- Misses       1116     1133      +17     
Flag Coverage Δ
unit 64.04% <0.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review June 3, 2024 10:44
@aranke aranke requested a review from a team as a code owner June 3, 2024 10:44
@aranke aranke added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@aranke aranke added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@aranke aranke added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 99d9727 Jun 4, 2024
18 checks passed
@aranke aranke deleted the move_catalogtable branch June 4, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants