-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move StatsItem
, StatsDict
, TableMetadata
to dbt-common
#141
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
e1ae142
to
ccfc4e5
Compare
dbt_common
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 64.78% 64.39% -0.40%
==========================================
Files 50 51 +1
Lines 3115 3134 +19
==========================================
Hits 2018 2018
- Misses 1097 1116 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dbt_common
StatsItem
, StatsDict
, TableMetadata
to dbt-common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment regarding the location of these classes but otherwise looks good! Thank you :)
Description
As per internal Slack conversation, we want to move the catalog artifact schema to
dbt-common
so adapters can depend on them (PR 1, PR 2).This PR moves the following to
dbt-common
:StatsItem
,StatsDict
,TableMetadata
Draft PR in
dbt-core
that keeps imports intact but uses code fromdbt-common
is here: dbt-labs/dbt-core#10238Checklist
changie new
to create a changelog entry