Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move StatsItem, StatsDict, TableMetadata to dbt-common #141

Merged
merged 12 commits into from
May 29, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented May 29, 2024

Description

As per internal Slack conversation, we want to move the catalog artifact schema to dbt-common so adapters can depend on them (PR 1, PR 2).

This PR moves the following to dbt-common: StatsItem, StatsDict, TableMetadata
Draft PR in dbt-core that keeps imports intact but uses code from dbt-common is here: dbt-labs/dbt-core#10238

Checklist

@cla-bot cla-bot bot added the cla:yes label May 29, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke marked this pull request as ready for review May 29, 2024 13:32
@aranke aranke requested a review from a team as a code owner May 29, 2024 13:32
@aranke aranke changed the title Move catalog artifact schema to dbt_common Move catalog artifact schema to dbt_common May 29, 2024
@aranke aranke assigned MichelleArk and unassigned MichelleArk May 29, 2024
@aranke aranke requested a review from MichelleArk May 29, 2024 13:46
@aranke aranke marked this pull request as draft May 29, 2024 15:35
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 64.39%. Comparing base (315aeae) to head (5caf8cb).

Files Patch % Lines
dbt_common/contracts/metadata.py 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   64.78%   64.39%   -0.40%     
==========================================
  Files          50       51       +1     
  Lines        3115     3134      +19     
==========================================
  Hits         2018     2018              
- Misses       1097     1116      +19     
Flag Coverage Δ
unit 64.39% <0.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review May 29, 2024 15:48
@aranke aranke changed the title Move catalog artifact schema to dbt_common Move StatsItem, StatsDict, TableMetadata to dbt-common May 29, 2024
Copy link
Collaborator

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment regarding the location of these classes but otherwise looks good! Thank you :)

@aranke aranke added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 50072e7 May 29, 2024
18 checks passed
@aranke aranke deleted the move_catalog_schema branch May 29, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants