Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support silence as part of WarnErrorOptions #111

Closed
1 task done
QMalcolm opened this issue Apr 20, 2024 · 0 comments · Fixed by #112
Closed
1 task done

Support silence as part of WarnErrorOptions #111

QMalcolm opened this issue Apr 20, 2024 · 0 comments · Fixed by #112
Assignees

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-common

Short description

In dbt-core we want to begin supporting silence as an option in WarnErrorOptions as described in dbt-labs/dbt-core#9644. About half of that work needs to be done here in dbt-common.

Acceptance criteria

  • WarnErrorOptions supports silenced
  • warn_or_error doesn't send any event if an event is silenced

Suggested Tests

  1. silence properly defaulted when instantiating WarnErrorOptions
  2. can specify events for silence when instantiating WarnErrorOptions
  3. specifying an invalid event name for silence when instantiating WarnErrorOptions raises an error
  4. events that have been silenced never emit during warn_or_error

Impact to Other Teams

N/A

Will backports be required?

Depends if we're okay with doing this as a patch or a minor release. It's completely optional and additive, so I can't imagine it breaking anyone as patch release.

Context

See dbt-labs/dbt-core#9644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant