Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline comments (--) on the last line of an incremental model (partition replacement) #991

Merged
merged 8 commits into from
Nov 8, 2023

Conversation

tnk-ysk
Copy link
Contributor

@tnk-ysk tnk-ysk commented Oct 28, 2023

resolves #896
docs dbt-labs/docs.getdbt.com/#

Problem

If an incremental model (with static partition replacement) has an inline SQL comment, this results in an invalid SQL statement.

Solution

Change so that there is a line break after the SQL.
Test has not been added as it is expected to be added by dbt-labs/dbt-core#8487

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@tnk-ysk tnk-ysk requested a review from a team as a code owner October 28, 2023 02:25
@tnk-ysk tnk-ysk requested a review from mikealfare October 28, 2023 02:25
@cla-bot cla-bot bot added the cla:yes label Oct 28, 2023
@mikealfare

This comment was marked as resolved.

@tnk-ysk

This comment was marked as resolved.

@mikealfare mikealfare self-assigned this Nov 7, 2023
@tnk-ysk tnk-ysk marked this pull request as draft November 8, 2023 01:42
@tnk-ysk tnk-ysk marked this pull request as ready for review November 8, 2023 02:00
@tnk-ysk
Copy link
Contributor Author

tnk-ysk commented Nov 8, 2023

@mikealfare
Sorry to bother you again.
I fixed test case because it was invalid.
Adding comment to existing test case was sufficient.

@mikealfare mikealfare merged commit bf30b66 into dbt-labs:main Nov 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants