Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish internal build workflow #1143

Merged
merged 9 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Under the Hood-20240320-193554.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Under the Hood
body: Finalize the bigquery internal release build workflow
time: 2024-03-20T19:35:54.550603-07:00
custom:
Author: versusfacit
Issue: "38"
42 changes: 9 additions & 33 deletions .github/workflows/release-internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,39 +8,15 @@ on:
type: string
required: true
sha:
description: "The sha to use (leave empty to use latest on main)"
description: "The ref (sha or branch name) to use"
type: string
required: false
package_test_command:
description: "Package test command"
type: string
default: "python -c \"import dbt.adapters.bigquery\""
default: "main"
required: true
dbms_name:
description: "The name of the warehouse the adapter connects to."
type: string
default: "bigquery"
required: true
workflow_call:
inputs:
version_number:
description: "The release version number (i.e. 1.0.0b1)"
type: string
required: true
sha:
description: "The sha to use (leave empty to use latest on main)"
type: string
required: false
package_test_command:
description: "Package test command"
type: string
default: "python -c \"import dbt.adapters.bigquery\""
required: true
dbms_name:
description: "The name of the warehouse the adapter connects to."
type: string
default: "bigquery"
required: true

defaults:
run:
Expand All @@ -51,14 +27,14 @@ env:

jobs:
invoke-reusable-workflow:
name: Build and Release Internally
name: "Build and Release Internally"

uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main
uses: "dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@mp/finish_internal_workflow"
Copy link
Contributor Author

@VersusFacit VersusFacit Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to change this once main has all the changes needed to support all the other workflows. Since this PR's workflow can be invoked using the branch reference, I'll merge at the time I can revert to main (unless there is an alternate path desired)


with:
version_number: ${{ inputs.version_number }}
package_test_command: ${{ inputs.package_test_command }}
dbms_name: ${{ inputs.dbms_name }}
sha: ${{ inputs.sha }}
version_number: "${{ inputs.version_number }}"
package_test_command: "${{ inputs.package_test_command }}"
dbms_name: "bigquery"
sha: "${{ inputs.sha }}"

secrets: inherit
secrets: "inherit"
Loading