Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image for 1.7.7 became much bigger that 1.7.6 #1160

Closed
2 tasks done
xemuliam opened this issue Mar 29, 2024 · 5 comments
Closed
2 tasks done

Docker image for 1.7.7 became much bigger that 1.7.6 #1160

xemuliam opened this issue Mar 29, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@xemuliam
Copy link
Contributor

xemuliam commented Mar 29, 2024

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Looks like smth. goes wrong with version 1.7.7
Changelog is tiny enough but actual size of docker image became unexpectedly big
image

Expected Behavior

I do expect to not see so much growth for image size. There must be very cardinal and significant changes inside to become 42% bigger than previous version

Steps To Reproduce

pull the 1.7.2, 1.7.4, 1.7.6 and1.7.7 versions from registry and compare sizes

Relevant log output

No response

Environment

No response

Additional Context

No response

@xemuliam xemuliam added bug Something isn't working triage labels Mar 29, 2024
@dataders
Copy link
Contributor

dataders commented Apr 1, 2024

@xemuliam #1154 addition of the [pandas] option might make the difference? You're right that I don't see much else going on.

I'll flag this internally though, but I'm not sure this qualifies as "bug".

@dataders dataders added enhancement New feature or request awaiting_response and removed bug Something isn't working triage labels Apr 1, 2024
@xemuliam
Copy link
Contributor Author

xemuliam commented Apr 1, 2024

I understand this issue doesn't look like a bug. However there were very few options to choose issue type

@mikealfare
Copy link
Contributor

@xemuliam #1154 addition of the [pandas] option might make the difference? You're right that I don't see much else going on.

I'll flag this internally though, but I'm not sure this qualifies as "bug".

Agreed, it's very likely [pandas]. And now that google-cloud-bigquery yanked 3.20, we can look to see if we can remove that requirement again for the next patch.

And agreed it's not quite a bug, but it's certainly an unexpected change.

@xemuliam
Copy link
Contributor Author

Here is the related information:
googleapis/python-bigquery#1880

@amychen1776
Copy link

Since dbt 1.7 is at its end of life, I'm going to close out this issue as not going to be do.

@amychen1776 amychen1776 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants