-
Notifications
You must be signed in to change notification settings - Fork 159
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implementation of metadata-based freshness (#1072)
* changelog * turn on metadata-based source freshness capability * add boundary test to confirm get_table raises an error properly * add metadata-based source freshness for a relation * remove unnecessary test setup * remove unnecessary fixture from test --------- Co-authored-by: colin-rogers-dbt <[email protected]>
- Loading branch information
1 parent
8a2b9ed
commit 24748d2
Showing
5 changed files
with
108 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: Add support for checking table-last-modified by metadata | ||
time: 2023-12-18T15:54:09.69635-05:00 | ||
custom: | ||
Author: mikealfare | ||
Issue: "938" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import pytest | ||
|
||
from dbt.tests.util import get_connection | ||
from google.cloud.bigquery import Client, DatasetReference, TableReference | ||
from google.api_core.exceptions import NotFound | ||
|
||
|
||
@pytest.mark.parametrize("table_name", ["this_table_does_not_exist"]) | ||
def test_get_table_does_not_exist(project, table_name): | ||
""" | ||
TODO: replace dbt project methods with direct connection instantiation | ||
""" | ||
with get_connection(project.adapter) as conn: | ||
client: Client = conn.handle | ||
dataset_ref = DatasetReference(project.database, project.test_schema) | ||
table_ref = TableReference(dataset_ref, table_name) | ||
with pytest.raises(NotFound): | ||
client.get_table(table_ref) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
SCHEMA_YML = """version: 2 | ||
sources: | ||
- name: test_source | ||
freshness: | ||
warn_after: {count: 10, period: hour} | ||
error_after: {count: 1, period: day} | ||
schema: "{{ env_var('DBT_GET_LAST_RELATION_TEST_SCHEMA') }}" | ||
tables: | ||
- name: test_source | ||
""" | ||
|
||
SEED_TEST_SOURCE_CSV = """ | ||
id,name | ||
1,Martin | ||
2,Jeter | ||
3,Ruth | ||
4,Gehrig | ||
5,DiMaggio | ||
6,Torre | ||
7,Mantle | ||
8,Berra | ||
9,Maris | ||
""".strip() |
30 changes: 30 additions & 0 deletions
30
tests/functional/adapter/sources_freshness_tests/test_get_relation_last_modified.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import os | ||
import pytest | ||
|
||
from dbt.tests.util import run_dbt | ||
|
||
from tests.functional.adapter.sources_freshness_tests import files | ||
|
||
|
||
class TestGetLastRelationModified: | ||
@pytest.fixture(scope="class") | ||
def seeds(self): | ||
return {"test_source.csv": files.SEED_TEST_SOURCE_CSV} | ||
|
||
@pytest.fixture(scope="class") | ||
def models(self): | ||
return {"schema.yml": files.SCHEMA_YML} | ||
|
||
@pytest.fixture(scope="class", autouse=True) | ||
def setup(self, project): | ||
# we need the schema name for the sources section | ||
os.environ["DBT_GET_LAST_RELATION_TEST_SCHEMA"] = project.test_schema | ||
run_dbt(["seed"]) | ||
yield | ||
del os.environ["DBT_GET_LAST_RELATION_TEST_SCHEMA"] | ||
|
||
def test_get_last_relation_modified(self, project): | ||
results = run_dbt(["source", "freshness"]) | ||
assert len(results) == 1 | ||
result = results[0] | ||
assert result.status == "pass" |