Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2624] [Spike] Scrutinize and clarify our approach and interface for transactions #347

Open
3 tasks done
dataders opened this issue Jun 1, 2023 · 3 comments
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@dataders
Copy link

dataders commented Jun 1, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

dbt-labs/dbt-redshift#475 and related issues have shaken my confidence that I could explain how dbt issues and handles transactions in ideal circumstances.

I propose that we refine the interface by which we create and issue transactions to make their usage clearer. As the result of this work may very well introduce breaking changes, it feels v2.0 might be an appropriate milestone for this spike and work.

two opportunities:

  • test explicitly for transaction behavior that we and users expect to see
  • pivot away from using the SQL API to begin and commit transactions as is done today in the run_hooks macro, and instead rely on the doing this in the python ConnectionManager class.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@dataders dataders added enhancement New feature or request triage labels Jun 1, 2023
@github-actions github-actions bot changed the title [Spike] Scrutinize and clarify our approach and interface for transactions [CT-2624] [Spike] Scrutinize and clarify our approach and interface for transactions Jun 1, 2023
@VersusFacit
Copy link
Contributor

VersusFacit commented Jun 2, 2023

Great followup item! Right now Snowflake and Redshift are set autocommit=on by default. As for default behavior of dbs and their profile options, it's unclear as to what's supported.

@dbeatty10 dbeatty10 removed the triage label Jun 4, 2023
Copy link

github-actions bot commented Dec 3, 2023

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 3, 2023
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@dataders dataders reopened this Apr 18, 2024
@dataders dataders transferred this issue from dbt-labs/dbt-core Apr 18, 2024
@dataders dataders transferred this issue from dbt-labs/dbt-redshift Apr 18, 2024
@github-actions github-actions bot removed the Stale label Jul 26, 2024
@dataders dataders transferred this issue from dbt-labs/dbt-core Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants