You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For now, workflow context sleep takes in duratioinSec. But JS/TS developers always expect millisecond sleep/timeout. We should match the common practice in V2.
We should also consider adding support for strings like "2 days", "30s" by using the ms package.
The text was updated successfully, but these errors were encountered:
devhawk
changed the title
[V2 feature] Transact durations should always be millisecond + support other strings
Transact durations should always be millisecond + support other strings
May 21, 2024
@qianl15 we could add ms package support to the existing sleep function without a breaking change. sleep and sleepms both take a number parameter. If we changed that to number | string we could use the ms if the user passes in a string. Should we separate the non breaking functionality out into a separate issue?
devhawk
changed the title
Transact durations should always be millisecond + support other strings
Transact durations should always be millisecond
May 21, 2024
For now, workflow context sleep takes in
duratioinSec
. But JS/TS developers always expect millisecond sleep/timeout. We should match the common practice in V2.We should also consider adding support for strings like "2 days", "30s" by using the ms package.The text was updated successfully, but these errors were encountered: