Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change endpoint to not include version #22

Closed
dblock opened this issue Jun 10, 2020 · 2 comments
Closed

Change endpoint to not include version #22

dblock opened this issue Jun 10, 2020 · 2 comments
Assignees

Comments

@dblock
Copy link
Owner

dblock commented Jun 10, 2020

As is, the README for stations API will not work because you need to use the api.openweathermap.org/data/3.0 endpoint.

I propose to add api_root (e.g. https://api.openweathermap.org), api_path, e.g. data, and api_version, then combine these into endpoint.

Then document that this now supports 2.5 and 3.0 endpoints.

@dblock
Copy link
Owner Author

dblock commented Jun 12, 2020

I did something simpler in #23, so you don't need to specify endpoint to use the stations and measurements APIs.

@dblock dblock closed this as completed Jun 12, 2020
@wasabigeek
Copy link
Collaborator

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants