CB-5918 Add new plugin #3081
CB-5918 Add new plugin #3081
Conversation
SychevAndrey
force-pushed
the
CB-5918-add-christmas
branch
from
ef95543
to
5c70343
Compare
| "@types/react": "*", | ||
| "typescript": "^5", | ||
| "typescript-plugin-css-modules": "*" |
There was a problem hiding this comment.
please same versions as in other packages
| "@cloudbeaver/core-administration": "^0", | ||
| "@cloudbeaver/core-authentication": "^0", | ||
| "@cloudbeaver/core-blocks": "^0", | ||
| "@cloudbeaver/core-connections": "^0", | ||
| "@cloudbeaver/core-data-context": "^0", | ||
| "@cloudbeaver/core-di": "^0", | ||
| "@cloudbeaver/core-dialogs": "^0", | ||
| "@cloudbeaver/core-events": "^0", | ||
| "@cloudbeaver/core-executor": "^0", | ||
| "@cloudbeaver/core-localization": "^0", | ||
| "@cloudbeaver/core-resource": "^0", | ||
| "@cloudbeaver/core-root": "^0", | ||
| "@cloudbeaver/core-routing": "^0", | ||
| "@cloudbeaver/core-sdk": "^0", | ||
| "@cloudbeaver/core-ui": "^0", | ||
| "@cloudbeaver/core-utils": "^0", | ||
| "@cloudbeaver/core-version": "^0", | ||
| "@cloudbeaver/core-view": "^0", | ||
| "@cloudbeaver/plugin-administration": "^0", | ||
| "@cloudbeaver/plugin-holidays": "^0", | ||
| "@cloudbeaver/plugin-settings-menu": "^0", | ||
| "@cloudbeaver/plugin-top-app-bar": "^0", |
There was a problem hiding this comment.
seems like too many dependencies for "App logo"
| override register(): void | Promise<void> { | ||
| override register() { | ||
| this.topNavService.placeholder.add(Logo, 0); | ||
| this.administrationTopAppBarService.placeholder.add(Logo, 0); | ||
| this.wizardTopAppBarService.placeholder.add(Logo, 0); |
There was a problem hiding this comment.
seems like you need to revert this change because Logo was added separately to the public and administration part on purpose
| "@cloudbeaver/core-blocks": "^0", | ||
| "@cloudbeaver/core-di": "^0", | ||
| "@cloudbeaver/core-utils": "^0", | ||
| "@cloudbeaver/plugin-administration": "^0", |
There was a problem hiding this comment.
In case this plugin depends on administration, you have two options:
Make two plugins:
plugin-holidays
plugin-holidays-administration
or make a single plugin
plugin-holidays-administration
(in that case, it should not affect the public part of the application)
This is because the administration part is optional as is public part, so we need this ability to turn off one of these parts
| this.topNavService.placeholder.add(HolidayButton, 4); | ||
| this.administrationTopAppBarService.placeholder.add(HolidayButton, 4); | ||
| } |
There was a problem hiding this comment.
same situation here, this service depends both on public and administration part, it needs to be split
| export interface IHoliday { | ||
| startDate: Date; | ||
| endDate: Date; | ||
| isHoliday: boolean; |
There was a problem hiding this comment.
holiday.isHoliaday is a bit weird, it may be active or ongoing or something else.
| logoSrc: string; | ||
| iconSrc: string; | ||
| activeIconSrc?: string; | ||
| isCelebrating: boolean; |
There was a problem hiding this comment.
Now I'm baffled; what is the difference between isHoliday?
It will be better to name it animationActive and actions like startAnimation, stopAnimation
(or maybe another word, but something to make some meaning difference with isHoliday
previously flakes kept x position that looked weird especially when user resize the window making it bigger
make flakes bigger and a little bit slower, reduce amount of flakes
add shape prop to create different shapes of snowflakes add drawSnowflake to render snowflakes
In order to customize Logo for different occasions without creating circular dependencies with other plugins
use holidays service to set custom logo
SychevAndrey
force-pushed
the
CB-5918-add-christmas
branch
from
2144324
to
2987ef5
Compare
webapp/packages/plugin-holidays/src/HolidayActionButton.module.css
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-app-logo-administration/src/PluginBootstrap.ts
Outdated
Show resolved
Hide resolved
| import { Bootstrap, injectable } from '@cloudbeaver/core-di'; | ||
| import { TopNavService } from '@cloudbeaver/plugin-top-app-bar'; | ||
|
|
||
| import { Logo } from './Logo.js'; |
There was a problem hiding this comment.
please use importLazyComponent - so main goal here is to initialize "business" logic as fast as possible and then load UI part so every time you import components in services use importLazyComponent
No description provided.