Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Viewing events tab causes panel to crash when using figwheel.main's :target :bundle option. #346

Closed
eval-on-point opened this issue Jan 11, 2022 · 2 comments
Labels

Comments

@eval-on-point
Copy link

eval-on-point commented Jan 11, 2022

What happened?

A bug happened! See some discussion in the Clojurians Slack here. I've prepared a minimal example here.

10x Version

1.2.1

Reagent Version

1.1.0

React Version

17.0.2

re-frame Version

1.2.0

What browsers are you seeing the problem on?

Chrome

Relevant console output

core.cljs:13 Uncaught TypeError: Cannot read properties of undefined (reading 'call')
    at cmp.re_highlight$core$did_mount (core.cljs:13:6)
    at cmp.reagent$impl$component$custom_wrapper_$_componentDidMount [as componentDidMount] (component.cljs:240:25)
    at commitLifeCycles (react-dom.development.js:19814:22)
    at commitLayoutEffects (react-dom.development.js:22803:7)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188:14)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237:16)
    at invokeGuardedCallback (react-dom.development.js:292:31)
    at commitRootImpl (react-dom.development.js:22541:9)
    at unstable_runWithPriority (scheduler.development.js:653:12)
    at runWithPriority$1 (react-dom.development.js:11039:10)
@p-himik
Copy link
Contributor

p-himik commented Jan 11, 2022

Pretty sure the root cause is that superstructor/re-highlight depends on highlight.js version 11.1.0 but re-frame-10x/project.clj specifies [cljsjs/highlight "10.3.1-0"].

@kimo-k
Copy link
Contributor

kimo-k commented Jul 26, 2023

We no longer depend on highlight.js, so hopefully this is fixed.

@kimo-k kimo-k closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants