Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the map generator to position tiles with top/left instead of inline positioning. #45

Open
davmillar opened this issue Oct 18, 2016 · 3 comments

Comments

@davmillar
Copy link
Owner

Maps are currently generated as rows of inline images. Ideally they should be made using images with position: absolute and with top and left values given.

@deathwebo
Copy link

What about a more modern solution like flexbox ? I could help with that

@davmillar
Copy link
Owner Author

@deathwebo that'd be an interesting idea, but I think absolute positioning would lend itself better for future enhancements to manual map editing and map export where CSS isn't necessarily involved.

@suniahk
Copy link
Contributor

suniahk commented Oct 9, 2019

What does absolute positioning solve can't be done with flexbox or simply inline positioning like is already implemented? Maybe I'm missing a detail here, but for manual map editing you'd be placing dummy divs instead of images to maintain click states, and exporting to canvas still respects css. I'm confused what this accomplishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants