Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SteamCodec::KeyValues doesn't work with // comments #2

Open
thth opened this issue Sep 26, 2015 · 1 comment
Open

SteamCodec::KeyValues doesn't work with // comments #2

thth opened this issue Sep 26, 2015 · 1 comment
Labels

Comments

@thth
Copy link

thth commented Sep 26, 2015

On input of KeyValues with // comments, SteamCodec::KeyValues::load returns nil.

The issue appears to be here, where only \\ is parsed as a comment, but according to the wiki and the file I'm working with, // and / should be comments. I also haven't seen \\ being indicated as being a KeyValues comment anywhere.

@davispuh
Copy link
Owner

hmm, I actually haven't encountered any file with comments, but yeah indeed I've messed up there.
// is comment, can see it in source-sdk-2013/sp/src/tier1/utlbuffer.cpp#412 But based on that implementation single / isn't comment.

@davispuh davispuh added the bug label Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants