Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toolbar work on mobile #81

Closed
pedronasser opened this issue Nov 7, 2013 · 7 comments
Closed

Make toolbar work on mobile #81

pedronasser opened this issue Nov 7, 2013 · 7 comments
Labels

Comments

@pedronasser
Copy link
Contributor

I've tested with my Galaxy Note and it didn't open.
It should work, right? What do you think?
I'll work something out.

@daviferreira
Copy link
Member

Since we use the mouseup event, it won't work. But I'm not sure if I want to go down that road 😨

@pedronasser
Copy link
Contributor Author

I'm not talking about a full support.
Just to provide a basic usability.
Nothing that complex.

@pedronasser
Copy link
Contributor Author

@daviferreira
No? Would be better this support as a plugin?

@daviferreira
Copy link
Member

Yeah, maybe a new object using MediumEditor prototype.

@linkesch
Copy link
Member

I started working on a mobile plugin today. Currently it only solves and issue when after selecting text on a mobile device (with longer touch), the editor's toolbar isn't visible. It's a work in progress. When I run into more issues on mobile devices, I'll try to come up with fixes.

It could be found here: https://github.com/orthes/medium-editor-mobile-plugin

@shyamal890
Copy link

Is there any updates to this? Is yabwe medium-editor going to support mobile browsers?

@wislem
Copy link

wislem commented Dec 1, 2016

What an old issue! But hey, here's a quick and dirty solution to anyone interested:

Add this line
this.on(this.document.documentElement, 'touchend', this.handleDocumentMouseup.bind(this));
right after
this.on(this.document.documentElement, 'mouseup', this.handleDocumentMouseup.bind(this));
found on medium-editor.js:5994

@orthes plugin does not seem to work properly with the latest version of medium-editor and I don't know how to fix it. So skip including that in your list of js and use the above solution.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants