Skip to content

Commit

Permalink
Merge branch 'master' into fix_4186
Browse files Browse the repository at this point in the history
  • Loading branch information
davidyuan1223 authored Sep 26, 2023
2 parents b616044 + e244029 commit 360d183
Show file tree
Hide file tree
Showing 867 changed files with 42,025 additions and 14,617 deletions.
2 changes: 1 addition & 1 deletion .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ github:
issues: true
discussions: true
wiki: false
projects: false
projects: true
notifications:
commits: [email protected]
issues: [email protected]
Expand Down
109 changes: 109 additions & 0 deletions .github/ISSUE_TEMPLATE/dependency.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

# See https://gh-community.github.io/issue-template-feedback/structured/

name: Dependency
title: ":arrow_up: Upgrade <artifact> from <current version> to <target version>"
description: Keep upstream dependencies fresh and stable
labels: [ "kind:build, priority:major, good first issue, help wanted" ]
body:
- type: markdown
attributes:
value: |
Thank you for finding the time to report the issue! We really appreciate the community's efforts to improve Kyuubi.
It doesn't really matter whether what you are reporting is a bug or not, just feel free to share the problem you have
encountered with the community. For best practices, if it is indeed a bug, please try your best to provide the reproducible
steps. If you want to ask questions or share ideas, please [subscribe to our mailing list](mailto:[email protected])
and send emails to [our mailing list](mailto:[email protected]), you can also head to our
[Discussions](https://github.com/apache/kyuubi/discussions) tab.
- type: checkboxes
attributes:
label: Code of Conduct
description: The Code of Conduct helps create a safe space for everyone. We require that everyone agrees to it.
options:
- label: >
I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
required: true
- type: checkboxes
attributes:
label: Search before asking
options:
- label: >
I have searched in the [issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no similar
issues.
required: true
- type: dropdown
id: priority
attributes:
label: Why do we need to upgrade this artifact?
options:
- Common Vulnerabilities and Exposures (CVE)
- Bugfixes
- Usage of New Features
- Performance Improvements
- Regular Updates
validations:
required: true

- type: input
id: artifact
attributes:
label: Artifact Name
description: Which artifact shall be upgraded?
placeholder: e.g. spark-sql
value: https://mvnrepository.com/search?q=
validations:
required: true

- type: input
id: versions
attributes:
label: Target Version
description: Which version shall be upgraded?
placeholder: e.g. 1.2.1
validations:
required: true

- type: textarea
id: changes
attributes:
label: Notable Changes
description: Please provide notable changes, or release notes if any
validations:
required: false

- type: checkboxes
attributes:
label: Are you willing to submit PR?
description: >
A pull request is optional, but we are glad to help you in the contribution process
especially if you already know a good understanding of how to implement the fix.
Kyuubi is a community-driven project and we love to bring new contributors in.
options:
- label: Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
- label: No. I cannot submit a PR at this time.

- type: markdown
attributes:
value: >
After changing the corresponding dependency version and before submitting your pull request,
it is necessary to execute `build/dependency.sh --replace` locally to update `dev/dependencyList`.
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,11 @@
# limitations under the License.
#

name: Doc Improvement Report
title: "[DOCS] "
name: Documentation fixes or improvement
title: ":memo: Fix/Add <what> for <which> page"
description: Fix errors, or improve the content or refactor architecture of online documentation
labels: ["kind:documentation"]
labels: ["kind:documentation,kind:minor,help wanted,good first issue"]
body:
- type: markdown
attributes:
value: |
Thank you for finding the time to report the problem! We really appreciate the community efforts to improve Kyuubi.
- type: checkboxes
attributes:
label: Code of Conduct
Expand All @@ -43,22 +38,25 @@ body:
issues.
required: true
- type: textarea
- type: dropdown
id: priority
attributes:
label: Which parts of the documentation do you think need improvement?
description: Please describe the details with documentation you have.
placeholder: >
Please include links to the documentation that you want to improve and possibly screenshots showing
the details. Explain why do you think it needs to improve. Make sure you include view of the target
audience of the documentation. Please explain why you think the docs are wrong.
label: What type of changes will we make to the documentation?
options:
- Bugfixes
- Usage of New Feature
- Showcase
- Refactoring
- Typo, layout, grammar, spelling, punctuation errors, etc.
validations:
required: true

- type: input
id: versions
attributes:
label: Affects Version(s)
description: Which versions of Kyuubi Documentation are affected by this issue?
placeholder: >
e.g. master/1.5.0/1.4.1/...
placeholder: e.g. master/1.5.0/1.4.1/...
validations:
required: true

Expand All @@ -67,20 +65,9 @@ body:
label: Improving the documentation
description: How do you think the documentation can be improved?
placeholder: >
Please explain how you think the documentation could be improved. Ideally specify where a new or missing
documentation should be added and what kind of information should be included. Sometimes people
writing the documentation do not realise that some assumptions they have might not be in the heads
of the reader, so try to explain exactly what you would like to see in the docs and why.
- type: textarea
attributes:
label: Anything else
description: Anything else we need to know?
placeholder: >
How often does this problem occur? (Once? Every time? Only when certain conditions are met?)
Any relevant logs to include? Put them here inside fenced
``` ``` blocks or inside a foldable details tag if it's long:
<details><summary>x.log</summary> lots of stuff </details>
Please include links to the documentation that you want to improve and possibly screenshots showing
the details. Explain why do you think it needs to improve. Make sure you include view of the target
audience of the documentation. Please explain why you think the docs are wrong.
- type: checkboxes
attributes:
Expand Down
11 changes: 10 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,13 @@ Please clarify why the changes are needed. For instance,

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request


### _Was this patch authored or co-authored using generative AI tooling?_
<!--
If a generative AI tooling has been used in the process of authoring this patch, please include
phrase 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,17 @@
# limitations under the License.
#

name: 'setup-mvnd'
description: 'Setup the maven daemon'
continue-on-error: true
name: setup-maven
description: 'Install and cache maven'
runs:
using: composite
steps:
- name: Cache Mvnd
- name: Restore cached Maven
uses: actions/cache@v3
with:
path: |
build/maven-mvnd-*
build/apache-maven-*
key: setup-mvnd-${{ runner.os }}
- name: Check Maven
run: build/mvn -v
shell: bash
- name: Check Mvnd
run: build/mvnd -v
path: build/apache-maven-*
key: setup-maven-${{ hashFiles('pom.xml') }}
restore-keys: setup-maven-
- name: Install Maven
shell: bash
run: build/mvn -v
6 changes: 5 additions & 1 deletion .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@

"module:server":
- "bin/kyuubi"
- "kyuubi-server/**/*"
- "kyuubi-server/src/**/*"
- "kyuubi-server/pom.xml"
- "extension/server/kyuubi-server-plugin/**/*"

"module:spark":
Expand All @@ -121,3 +122,6 @@

"module:authz":
- "extensions/spark/kyuubi-spark-authz/**/*"

"module:ui":
- "kyuubi-server/web-ui/**/*"
9 changes: 4 additions & 5 deletions .github/workflows/dep.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ on:
# when pom or dependency workflow changes
- '**/pom.xml'
- '.github/workflows/dep.yml'
- .github/actions/setup-mvnd/*.yaml

concurrency:
group: dep-${{ github.head_ref || github.run_id }}
Expand All @@ -45,12 +44,12 @@ jobs:
java-version: 8
cache: 'maven'
check-latest: false
- name: Setup Mvnd
uses: ./.github/actions/setup-mvnd
- name: Setup Maven
uses: ./.github/actions/setup-maven
- name: Check kyuubi modules available
id: modules-check
run: >-
build/mvnd dependency:resolve validate -q
build/mvn dependency:resolve validate
-DincludeGroupIds="org.apache.kyuubi" -DincludeScope="compile"
-Pfast -Denforcer.skip=false
-pl kyuubi-ctl,kyuubi-server,kyuubi-assembly -am
Expand All @@ -60,7 +59,7 @@ jobs:
MAVEN_OPTS: -Dorg.slf4j.simpleLogger.defaultLogLevel=error
if: steps.modules-check.conclusion == 'success' && steps.modules-check.outcome == 'failure'
run: >-
build/mvnd clean install
build/mvn clean install
-Pflink-provided,spark-provided,hive-provided
-Dmaven.javadoc.skip=true
-Drat.skip=true
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/license.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,10 @@ jobs:
java-version: 8
cache: 'maven'
check-latest: false
- name: Setup Mvnd
uses: ./.github/actions/setup-mvnd
- run: >-
build/mvnd org.apache.rat:apache-rat-plugin:check
build/mvn org.apache.rat:apache-rat-plugin:check
-Ptpcds -Pspark-block-cleaner -Pkubernetes-it
-Pspark-3.1 -Pspark-3.2 -Pspark-3.3
-Pspark-3.1 -Pspark-3.2 -Pspark-3.3 -Pspark-3.4
- name: Upload rat report
if: failure()
uses: actions/upload-artifact@v3
Expand Down
Loading

0 comments on commit 360d183

Please sign in to comment.