Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P_Batt forecast value calculation issue #343

Open
martinarva opened this issue Sep 10, 2024 · 3 comments
Open

P_Batt forecast value calculation issue #343

martinarva opened this issue Sep 10, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@martinarva
Copy link

Describe the bug

P_Batt forecast value calculation uses eta_disch as a multiplier and this causes issue where p_batt is lower than it should be.

For example at the moment max sell from battery should be happening.

Pd_max: 15600
eta_disch: 0.95

P_batt should be 15600, but it is 15600 * 0.95 =14 820

image

I'm using p_batt in automation to set the discharge power and in this case losing some power.

Expected behavior
Would be nice to get the real b_batt value. I think it would be beneficial for utilizing battery the most. Maybe it will be a possibility to make the eta_disch calculation for after the p_batt so that load and grid would be correct.

@davidusb-geek
Copy link
Owner

It could be that we need to apply the efficiency factor before publishing the battery power sensor?
It is something we have missed all along the way.
In the meantime you can also apply this efficiency on HA just before controlling your equipment

@davidusb-geek davidusb-geek added the bug Something isn't working label Sep 28, 2024
@martinarva
Copy link
Author

It could be that we need to apply the efficiency factor before publishing the battery power sensor? It is something we have missed all along the way. In the meantime you can also apply this efficiency on HA just before controlling your equipment

Great and yes, i'm applying this efficiency in HA at the moment.

@purcell-lab
Copy link
Contributor

I have been setting discharge efficiency to 1.00 to workaround this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants