Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of self-consumption optimization is always bigm, never maxmin #141

Closed
michaelpiron opened this issue Dec 27, 2023 · 4 comments
Closed

Comments

@michaelpiron
Copy link
Contributor

Hi @davidusb-geek ,

In the code, I noticed that in case of a self-consumption cost function, the optimizer always applies the so-called "bigm" method, due to this hard-coded parameter:

type_self_conso = 'bigm' # maxmin

However, the documentation explains the "maxmin" method, which is never invoked due to the parameter above.
Is there an issue with the maxmin method (e.g. never leads to a solution)?

Happy to help further, based on your reply.

@davidusb-geek
Copy link
Owner

davidusb-geek commented Dec 27, 2023

Yes it is hard coded to big M. It was long time ago but I think that the other method has convergence problems, probably the equations are not well posed. The big M was a second possible method but the maxmin is the elegant correct way to handle this.
Of course that you can help, all contributions are more than welcomed.
If you are interested we have another problem in the constraints section with constraints: set_def_const and treat_def_as_semi_cont. The don't seem to be compatible and are causing infeasible issues.

@michaelpiron
Copy link
Contributor Author

Ok, I will adapt the documentation to reflect the reality that self-consumption cost function uses the big M method.

regarding the other issue on constraints, is there already a bug report of this? If not, can you provide more input/evidence of the issue?

thx

@davidusb-geek
Copy link
Owner

regarding the other issue on constraints, is there already a bug report of this? If not, can you provide more input/evidence of the issue?

I dived into this other issue and it is solved in the current release.

@michaelpiron
Copy link
Contributor Author

Updated the optimizer documentation here: #143
It now describes that self-consumption has two methods (bigM and maxmin), and that currently only method bigM is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants