Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Numerical Syntax #104

Closed
JoshC1994 opened this issue Aug 16, 2023 · 9 comments
Closed

Feature Request: Numerical Syntax #104

JoshC1994 opened this issue Aug 16, 2023 · 9 comments

Comments

@JoshC1994
Copy link

Describe the bug
The Syntax of numbers shown in the "Last Run Optimisation Results Table" sometimes displaying as scientific numbers.
image

Why
The fact may be simply due to the input data EMHASS is being fed and the maths being calculated so that the resulting number is too great for the plotly table to display.

Fix
Would it cause too many issues with resolution if EMHASS only considered data and calculated the resultant to say 2 decimal points. I would think that any more resolution is only adding complexity and would require unnecessary compute resources.
Maybe the decimal count could be set via config?

I might be missing something but in most use cases I think that 2 decimal places would be enough resolution.

@davidusb-geek
Copy link
Owner

davidusb-geek commented Aug 16, 2023

Yes this can be easily fixed. We just to round to 2 decimal points when rendering the table. I'll add this to the next release.

@purcell-lab
Copy link
Contributor

Thanks @JoshC1994 , I have been having this issue as well.

@davidusb-geek while you are fixing the rounding could I suggest some additional improvements:

Could I suggest that all the power values be rounded to 0 decimal places.

P_PV and P_Load are already displayed as int, but the other P_ variables are displayed with a lot of unnecessary precision and it would be good if they could also be displayed as int, cost_profit & cost_fun could also potentially be rounded to 2 decimal places:

Screenshot 2023-08-17 07 00 45

@davidusb-geek
Copy link
Owner

Yes sure, no problem with these improvements.

@davidusb-geek
Copy link
Owner

Solved here: #105
Will be available in the next release.

@kcoffau
Copy link

kcoffau commented Aug 22, 2023

+1 thank you! @davidusb-geek

Appreciate everything you do for this project!

@purcell-lab
Copy link
Contributor

Nice work, much more readable:

image

@davidusb-geek
Copy link
Owner

Great! Closing this as completed.

@purcell-lab
Copy link
Contributor

I know this issue is closed, but the Power values seem to have snuck back in with unnecessary decimal (.0) again.
image

@davidusb-geek
Copy link
Owner

This is solved in the (just-to-be-released) new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants