Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace grimzy/laravel-mysql-spatial by matanyadaev/laravel-eloquent-spatial #40

Open
vesper8 opened this issue Mar 2, 2022 · 4 comments

Comments

@vesper8
Copy link

vesper8 commented Mar 2, 2022

It's become pretty clear that grimzy/laravel-mysql-spatial is abandoned and there's been a migration to matanyadaev/laravel-eloquent-spatial which is actively maintained, does everything that grimzy/laravel-mysql-spatial did and is future proof (supports Laravel 9 and PHP 8.1.

I personally just migrated a rather large project from grimzy/laravel-mysql-spatial to matanyadaev/laravel-eloquent-spatial and am happy to report the migration was very easy and quite painless, taking me only about 1 hour including testing that everything still works.

My only dependence on grimzy/laravel-mysql-spatial now is your package here, which I find very useful and am glad for.

On that note, it would be truly fantastic if you also migrated to matanyadaev/laravel-eloquent-spatial : )

I think you will find it quite easy and simple to do so.

Many thanks for the consideration!

@pelmered
Copy link
Contributor

pelmered commented Apr 4, 2022

Same situation here.

@davidpiesse
Copy link
Owner

Thanks for the suggestion.

I am waiting for Nova 4 to launch tomorrow before making any improvements.
This package may receive an update shortly.

If you want to PR a update I would be happy to include the change. The ability to remove grimzy would be nice.

D

@sutcliffe121
Copy link
Contributor

sutcliffe121 commented Jun 3, 2022

Although it's a required dependency, I don't think the grimzy/laravel-mysql-spatial package is actually used in the current package version? The only reference I can find is a function that is commented out in src/Map.php

image

@davidpiesse
Copy link
Owner

Could you submit a PR with the package removed?
It does look like it was only used for a planned editing functionality, which was not yet implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants