Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Gerrit and oauth provider #106

Open
karooga opened this issue Apr 10, 2018 · 4 comments
Open

Compatibility Gerrit and oauth provider #106

karooga opened this issue Apr 10, 2018 · 4 comments

Comments

@karooga
Copy link

karooga commented Apr 10, 2018

It looks like the compatibility of the plugin is dependent on the version of Gerrit used?

So the latest plugin version is 2.14.6.2:

https://github.com/davido/gerrit-oauth-provider/releases/tag/v2.14.6.2

and Gerrit 2.14.6:

https://www.gerritcodereview.com/releases/2.14.md

Despite Gerrit 2.14.7 being available as well as Gerrit 2.15.1:

https://www.gerritcodereview.com/releases/2.15.md

@mwebber
Copy link
Contributor

mwebber commented Apr 10, 2018

I can confirm that the latest release of this plugin (2.14.6.2) works well with both Gerrit 2.14.7 and 2.15 (haven't tested 2.15.1).
The OAuth Provider plugin is only fairly weakly dependent on the Gerrit version, so a new release of OAuth Provider is not usually required just because Gerrit has changed.

I agreed that we could make this clearer here.

@karooga
Copy link
Author

karooga commented Apr 10, 2018

That's good to know. Thanks @mwebber.

@davido
Copy link
Owner

davido commented Apr 10, 2018

Good point. I will release new plugin versions built against the latest API versions.

As @mwebber pointed out, it is safe to use the latest released plugin version. Another option would be to fetch the binary artifact from GerritForge CI: [1], from master (as you can see, there is no specific stable-2.15 branch and version on the CI).

@zesstra
Copy link

zesstra commented Apr 17, 2018

Thanks for this info as well, very useful. :-) +1 for including it in the documentation.
Now I can confirm that 2.14.6.2 works (as expected by you) for gerrit 2.15.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants