Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mid-paragraph punctuation has weird line breaks #82

Open
jez opened this issue Oct 30, 2024 · 1 comment
Open

Mid-paragraph punctuation has weird line breaks #82

jez opened this issue Oct 30, 2024 · 1 comment
Assignees

Comments

@jez
Copy link

jez commented Oct 30, 2024

Context

Due to the discussion in #52, the following lines were added to typeset.css:

.pull-double, .push-double,
.pull-single, .push-single {display: inline-block}

The quoted reason was that mid-paragraph punctuation was not hanging properly. See "Thrice:

image

Bug

These inline-block styles cause a problem.

If typeset.css includes these lines, then the " character is not rendered on the same line as the word it attaches to:

image

As it happens, the version of typeset.css which is currently being served on the demo does not include any inline-block styling—I had to explicitly add the inline-block styles in the web inspector to take this screenshot.

But, this does not appear to matter? The original bug reported in #52 does not reproduce for me in Chrome, Firefox, nor Safari on macOS. That is: the typeset.css file that's currently being served in the demo is sufficient to get mid-paragraph quotes to hang into the margin:

image

It would seem that these styles are no longer relevant. I'm not sure what would have changed here—maybe the original bug was reported when there was a bug in Chrome that has since been fixed?

Solution(s)

It should be sufficient to edit the README.md and the copies of typeset.css in this repo to drop any lines adding an inline-block style to the push/pull spans. This is what I will be doing in my own uses of this project.

It's also worth noting that in this comment: #52 (comment) mbutterick mentioned that his suggestion for fixing the original bug was to only have the inline-block on the push spans, not the pull spans. That appears to also work: mid-paragraph punctuation both hangs and also wraps alongside the following word.

@danielhaim1 danielhaim1 self-assigned this Dec 14, 2024
@danielhaim1
Copy link
Collaborator

Thanks for your note @jez I'll be doing some cleaning this coming week, I'll have a closer look and try to track down the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants