You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The quoted reason was that mid-paragraph punctuation was not hanging properly. See "Thrice:
Bug
These inline-block styles cause a problem.
If typeset.css includes these lines, then the " character is not rendered on the same line as the word it attaches to:
As it happens, the version of typeset.css which is currently being served on the demo does not include any inline-block styling—I had to explicitly add the inline-block styles in the web inspector to take this screenshot.
But, this does not appear to matter? The original bug reported in #52 does not reproduce for me in Chrome, Firefox, nor Safari on macOS. That is: the typeset.css file that's currently being served in the demo is sufficient to get mid-paragraph quotes to hang into the margin:
It would seem that these styles are no longer relevant. I'm not sure what would have changed here—maybe the original bug was reported when there was a bug in Chrome that has since been fixed?
Solution(s)
It should be sufficient to edit the README.md and the copies of typeset.css in this repo to drop any lines adding an inline-block style to the push/pull spans. This is what I will be doing in my own uses of this project.
It's also worth noting that in this comment: #52 (comment) mbutterick mentioned that his suggestion for fixing the original bug was to only have the inline-block on the push spans, not the pull spans. That appears to also work: mid-paragraph punctuation both hangs and also wraps alongside the following word.
The text was updated successfully, but these errors were encountered:
Context
Due to the discussion in #52, the following lines were added to
typeset.css
:The quoted reason was that mid-paragraph punctuation was not hanging properly. See
"Thrice
:Bug
These
inline-block
styles cause a problem.If
typeset.css
includes these lines, then the"
character is not rendered on the same line as the word it attaches to:As it happens, the version of
typeset.css
which is currently being served on the demo does not include anyinline-block
styling—I had to explicitly add theinline-block
styles in the web inspector to take this screenshot.But, this does not appear to matter? The original bug reported in #52 does not reproduce for me in Chrome, Firefox, nor Safari on macOS. That is: the
typeset.css
file that's currently being served in the demo is sufficient to get mid-paragraph quotes to hang into the margin:It would seem that these styles are no longer relevant. I'm not sure what would have changed here—maybe the original bug was reported when there was a bug in Chrome that has since been fixed?
Solution(s)
It should be sufficient to edit the README.md and the copies of
typeset.css
in this repo to drop any lines adding aninline-block
style to the push/pull spans. This is what I will be doing in my own uses of this project.It's also worth noting that in this comment: #52 (comment) mbutterick mentioned that his suggestion for fixing the original bug was to only have the
inline-block
on the push spans, not the pull spans. That appears to also work: mid-paragraph punctuation both hangs and also wraps alongside the following word.The text was updated successfully, but these errors were encountered: