Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language switch changes rules? #26

Open
alexisargyris opened this issue Sep 4, 2015 · 3 comments
Open

language switch changes rules? #26

alexisargyris opened this issue Sep 4, 2015 · 3 comments
Labels

Comments

@alexisargyris
Copy link

Found three small issues, all related to different behaviour when processing greek characters, instead of latin.

Problem 1: single quote before space

correctwrong
inputenglish' englishελληνικά' ελληνικά
outputenglish’ englishελληνικά′ ελληνικά

Problem 2: double quotes before full stop

correctwrong
input"english"."ελληνικά".
output“english”.“ελληνικά“.

Problem 3: double quotes before comma

correctwrong
input"english","ελληνικά",
output“english”,“ελληνικά“,
@davidmerfield
Copy link
Owner

Ah I think I know what's going on. I believe the regular expression handling the quote replacement doesn't consider 'ά' to be a letter. This is something which can be fixed without needing to specify a language.

I believe [a-z] in quotes.js needs to be modified to match accented characters too.

@alexisargyris
Copy link
Author

I tried with no accent and I still get open double quotes

@alexisargyris
Copy link
Author

For your reference here is what I use as test input. The format is "greek // english"

ένα' δύο // one' two

ένα'δύο // one'two

ένα 'δύο // one 'two

"καλα" // "one"

"καλα". // "one".

"καλα", // "one",

"καλά" // "one"

"καλά". // "one".

"καλά", // "one",

ένα–και–ένα // one–on–one

ένα – και – ένα // one – on – one

ένα--και--ένα // one--on--one

ένα -- και -- ένα // one -- on -- one

καλά... // good...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants