From cac8c9deb391934f3b56865de269272ba756619a Mon Sep 17 00:00:00 2001 From: David LJ Date: Fri, 22 Nov 2024 13:18:55 +0100 Subject: [PATCH 1/2] feat: add support for Angular v19 --- .../ngx-meta/docs/content/misc/bundle-size.md | 1 + projects/ngx-meta/docs/content/why/comparison.md | 2 +- projects/ngx-meta/docs/content/why/features.md | 2 +- projects/ngx-meta/e2e/README.md | 4 ++-- .../example-apps/angular-cli-versions.json | 3 ++- projects/ngx-meta/src/README.md | 2 +- projects/ngx-meta/src/package.json | 6 +++--- renovate.json5 | 16 +++++++++++++++- 8 files changed, 26 insertions(+), 10 deletions(-) diff --git a/projects/ngx-meta/docs/content/misc/bundle-size.md b/projects/ngx-meta/docs/content/misc/bundle-size.md index 5b24922c..0debc6ea 100644 --- a/projects/ngx-meta/docs/content/misc/bundle-size.md +++ b/projects/ngx-meta/docs/content/misc/bundle-size.md @@ -6,6 +6,7 @@ In order to keep library take as few bytes as possible from your app's bundle si Here's how much bytes the library takes of your main bundle size when using all its features: +--8<-- "includes/bundle-size/v19/bundle-size-report.md" --8<-- "includes/bundle-size/v18/bundle-size-report.md" --8<-- "includes/bundle-size/v17/bundle-size-report.md" --8<-- "includes/bundle-size/v16/bundle-size-report.md" diff --git a/projects/ngx-meta/docs/content/why/comparison.md b/projects/ngx-meta/docs/content/why/comparison.md index 5fe39707..1fb299f4 100644 --- a/projects/ngx-meta/docs/content/why/comparison.md +++ b/projects/ngx-meta/docs/content/why/comparison.md @@ -48,7 +48,7 @@ It is certainly a better option than installing a poorly maintained library. But | Maintenance | 🙋 `ngx-meta` | `@avivharuzi/ngx-seo` | `@ngaox/seo` | `@ngx-meta/core` | | --------------------------------- | :-------------------------: | :-----------------------------: | :-----------------------------------: | :---------------------------------: | -| :simple-angular: versions support | [**v15-v18**][pkg-this][^6] | [v13-16][pkg-ngx-seo] | [v15][pkg-ngaox-seo] | [v9][pkg-ngx-meta] | +| :simple-angular: versions support | [**v15-v19**][pkg-this][^6] | [v13-16][pkg-ngx-seo] | [v15][pkg-ngaox-seo] | [v9][pkg-ngx-meta] | | Documentation | ✅ | ✅ | ✅ | ✅ | | Last commit | [![lc-this]][repo-this] | [![lc-ngx-seo]][repo-ngx-seo] | [![lc-ngaox-seo]][repo-ngaox-seo] | [![lc-ngx-meta]][repo-ngx-meta] | | Unit tests | [![ci-b-this]][ci-l-this] | [![ci-b-ngx-seo]][ci-l-ngx-seo] | [![ci-b-ngaox-seo]][ci-l-ngaox-seo] | [![ci-b-ngx-meta]][ci-l-ngx-meta] | diff --git a/projects/ngx-meta/docs/content/why/features.md b/projects/ngx-meta/docs/content/why/features.md index 16a7bce6..00b047e1 100644 --- a/projects/ngx-meta/docs/content/why/features.md +++ b/projects/ngx-meta/docs/content/why/features.md @@ -17,7 +17,7 @@ Actually, a series of E2E tests are in place to ensure support for SSR and hydra ### 🤝 Compatibility with [Angular actively supported versions] -Right now being Angular v16, v17 and v18. Update from an Angular version to another when you're ready: this library won't be an issue! Latest version will be compatible with all [Angular actively supported versions]. [There are some E2E tests to ensure that indeed][E2E tests] +Right now being Angular v17, v18 and v19. Update from an Angular version to another when you're ready: this library won't be an issue! Latest version will be compatible with all [Angular actively supported versions]. [There are some E2E tests to ensure that indeed][E2E tests] !!! info "Older versions may be supported" diff --git a/projects/ngx-meta/e2e/README.md b/projects/ngx-meta/e2e/README.md index 1f23a10e..ae685810 100644 --- a/projects/ngx-meta/e2e/README.md +++ b/projects/ngx-meta/e2e/README.md @@ -45,10 +45,10 @@ First, build an example app. Then run ```sh -pnpm run test v18 +pnpm run test v19 ``` -Where v18 is the directory name of the example app. A script will automatically serve the built app, start tests and then stop serving the app. +Where v19 is the directory name of the example app. A script will automatically serve the built app, start tests and then stop serving the app. If code is instrumented for coverage reporting, the JSON report filename will be suffixed with the app name being tested. diff --git a/projects/ngx-meta/example-apps/angular-cli-versions.json b/projects/ngx-meta/example-apps/angular-cli-versions.json index 7a5ea966..2be1ba37 100644 --- a/projects/ngx-meta/example-apps/angular-cli-versions.json +++ b/projects/ngx-meta/example-apps/angular-cli-versions.json @@ -10,6 +10,7 @@ "v15": "npm:@angular/cli@15.2.11", "v16": "npm:@angular/cli@16.2.15", "v17": "npm:@angular/cli@17.3.9", - "v18": "npm:@angular/cli@18.2.3" + "v18": "npm:@angular/cli@18.2.3", + "v19": "npm:@angular/cli@19.0.0" } } diff --git a/projects/ngx-meta/src/README.md b/projects/ngx-meta/src/README.md index fe8390c1..6269df54 100644 --- a/projects/ngx-meta/src/README.md +++ b/projects/ngx-meta/src/README.md @@ -1,6 +1,6 @@ ![ for Angular](../docs/content/images/logo.png) -[![Angular](https://img.shields.io/badge/Works_with-Angular_v15--v18-f11653?logo=angular&logoColor=white&link=https%3A%2F%2Fangular.dev%2F)](https://angular.dev/) +[![Angular](https://img.shields.io/badge/Works_with-Angular_v15--v19-f11653?logo=angular&logoColor=white&link=https%3A%2F%2Fangular.dev%2F)](https://angular.dev/) [![Supports Angular SSR/Universal](https://custom-icon-badges.demolab.com/badge/Supports-Angular_SSR%2FUniversal-blue.svg?logo=angular-universal&link=https%3A%2F%2Fangular.dev%2Fguide%2Fssr)][SSR] [![NPM Downloads](https://img.shields.io/npm/dt/%40davidlj95%2Fngx-meta?logo=npm&label=NPM%20downloads&link=https%3A%2F%2Fwww.npmjs.com%2Fpackage%2F%40davidlj95%2Fngx-meta)](https://www.npmjs.com/package/@davidlj95/ngx-meta) diff --git a/projects/ngx-meta/src/package.json b/projects/ngx-meta/src/package.json index 17dc0f8f..ed1b91a9 100644 --- a/projects/ngx-meta/src/package.json +++ b/projects/ngx-meta/src/package.json @@ -37,9 +37,9 @@ "tslib": "^2.3.0" }, "peerDependencies": { - "@angular/common": "^18 || ^17 || ^16 || ^15", - "@angular/core": "^18 || ^17 || ^16 || ^15", - "@angular/router": "^18 || ^17 || ^16 || ^15" + "@angular/common": "^19 || ^18 || ^17 || ^16 || ^15", + "@angular/core": "^19 || ^18 || ^17 || ^16 || ^15", + "@angular/router": "^19 || ^18 || ^17 || ^16 || ^15" }, "peerDependenciesMeta": { "@angular/router": { diff --git a/renovate.json5 b/renovate.json5 index 6fb41f07..cc474b62 100644 --- a/renovate.json5 +++ b/renovate.json5 @@ -58,7 +58,7 @@ matchUpdateTypes: ['minor', 'patch', 'pin', 'digest'], automerge: true, }, - // Angular v18 + // Angular version installed { matchDepNames: ['@angular{/,}**'], matchFileNames: ['package.json'], @@ -86,6 +86,20 @@ matchDepNames: ['v17'], allowedVersions: '^17', }, + { + matchFileNames: [ + 'projects/ngx-meta/example-apps/angular-cli-versions.json', + ], + matchDepNames: ['v18'], + allowedVersions: '^18', + }, + { + matchFileNames: [ + 'projects/ngx-meta/example-apps/angular-cli-versions.json', + ], + matchDepNames: ['v19'], + allowedVersions: '^19', + }, // API Documenter to use Markdown tables // Watching issue to see if we can upgrade when fixed // https://github.com/microsoft/rushstack/issues/4586 From f81aa9b1450b24ff45499b806c456354137cdd36 Mon Sep 17 00:00:00 2001 From: David LJ Date: Fri, 22 Nov 2024 13:25:50 +0100 Subject: [PATCH 2/2] build(ide): update WebStorm run configs to run with v19 --- ...port.xml => ngx_meta_bundle_size_v19__report.xml} | 6 +++--- ...a_e2e_v19__build_with_coverage__serve___test.xml} | 10 +++++----- ...meta_example_apps_v19__build___compare_sizes.xml} | 12 ++++++------ ... => ngx_meta_example_apps_v19__build___serve.xml} | 8 ++++---- ...gx_meta_example_apps_v19__create_example_app.xml} | 2 +- 5 files changed, 19 insertions(+), 19 deletions(-) rename .idea/runConfigurations/{ngx_meta_bundle_size_v18__report.xml => ngx_meta_bundle_size_v19__report.xml} (83%) rename .idea/runConfigurations/{ngx_meta_e2e_v18__build_with_coverage__serve___test.xml => ngx_meta_e2e_v19__build_with_coverage__serve___test.xml} (82%) rename .idea/runConfigurations/{ngx_meta_example_apps_v18__build___compare_sizes.xml => ngx_meta_example_apps_v19__build___compare_sizes.xml} (86%) rename .idea/runConfigurations/{ngx_meta_example_apps_v18__build___serve.xml => ngx_meta_example_apps_v19__build___serve.xml} (86%) rename .idea/runConfigurations/{ngx_meta_example_apps_v18__create_example_app.xml => ngx_meta_example_apps_v19__create_example_app.xml} (63%) diff --git a/.idea/runConfigurations/ngx_meta_bundle_size_v18__report.xml b/.idea/runConfigurations/ngx_meta_bundle_size_v19__report.xml similarity index 83% rename from .idea/runConfigurations/ngx_meta_bundle_size_v18__report.xml rename to .idea/runConfigurations/ngx_meta_bundle_size_v19__report.xml index bd86c79a..eda40151 100644 --- a/.idea/runConfigurations/ngx_meta_bundle_size_v18__report.xml +++ b/.idea/runConfigurations/ngx_meta_bundle_size_v19__report.xml @@ -1,11 +1,11 @@ - +