From f1f9420ddb003a31040e36de5b70a32587f2c1d5 Mon Sep 17 00:00:00 2001
From: David LJ <mail@davidlj95.com>
Date: Tue, 12 Nov 2024 22:09:33 +0100
Subject: [PATCH] build: sort `package.json` files (#1032)

* build: sort `package.json` files

* build: remove unneeded `ng` run script

* style: rename codecov yml validator run script

* build: add validate script & rename them

* build: remove `cache-clean` run script

Use `exec` for JetBrains run configurations
---
 .eslintrc.json                                |  3 +-
 ...v18__build_with_coverage__serve___test.xml | 13 ++---
 ...xample_apps_v18__build___compare_sizes.xml |  7 +--
 ...x_meta_example_apps_v18__build___serve.xml |  7 +--
 package.json                                  | 58 +++++++++----------
 projects/ngx-meta/bundle-size/package.json    |  6 +-
 projects/ngx-meta/e2e/package.json            |  6 +-
 projects/ngx-meta/example-apps/package.json   | 12 ++--
 projects/ngx-meta/schematics/package.json     |  4 +-
 projects/ngx-meta/src/package.json            | 14 ++---
 10 files changed, 60 insertions(+), 70 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 49524997..40e13c90 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -57,7 +57,8 @@
       "rules": {
         "json-files/require-unique-dependency-names": "error",
         "json-files/ensure-repository-directory": "error",
-        "json-files/restrict-ranges": ["error", { "versionHint": "pin" }]
+        "json-files/restrict-ranges": ["error", { "versionHint": "pin" }],
+        "json-files/sort-package-json": "error"
       }
     }
   ]
diff --git a/.idea/runConfigurations/ngx_meta_e2e_v18__build_with_coverage__serve___test.xml b/.idea/runConfigurations/ngx_meta_e2e_v18__build_with_coverage__serve___test.xml
index dd5d96cd..3d2b8652 100644
--- a/.idea/runConfigurations/ngx_meta_e2e_v18__build_with_coverage__serve___test.xml
+++ b/.idea/runConfigurations/ngx_meta_e2e_v18__build_with_coverage__serve___test.xml
@@ -11,10 +11,8 @@
     <method v="2">
       <option name="NpmBeforeRunTask" enabled="true">
         <package-json value="$PROJECT_DIR$/package.json" />
-        <command value="run" />
-        <scripts>
-          <script value="cache-clean" />
-        </scripts>
+        <command value="exec" />
+        <arguments value="ng cache clean" />
         <node-interpreter value="project" />
         <envs />
       </option>
@@ -31,11 +29,8 @@
       <option name="RunConfigurationTask" enabled="true" run_configuration_name="ngx-meta/example-apps/v18: create example app" run_configuration_type="NodeJSConfigurationType" />
       <option name="NpmBeforeRunTask" enabled="true">
         <package-json value="$PROJECT_DIR$/projects/ngx-meta/example-apps/apps/v18/package.json" />
-        <command value="run" />
-        <scripts>
-          <script value="ng" />
-        </scripts>
-        <arguments value="cache clean" />
+        <command value="exec" />
+        <arguments value="ng cache clean" />
         <node-interpreter value="project" />
         <envs />
       </option>
diff --git a/.idea/runConfigurations/ngx_meta_example_apps_v18__build___compare_sizes.xml b/.idea/runConfigurations/ngx_meta_example_apps_v18__build___compare_sizes.xml
index 89174c8c..43e883c0 100644
--- a/.idea/runConfigurations/ngx_meta_example_apps_v18__build___compare_sizes.xml
+++ b/.idea/runConfigurations/ngx_meta_example_apps_v18__build___compare_sizes.xml
@@ -18,11 +18,8 @@
       </option>
       <option name="NpmBeforeRunTask" enabled="true">
         <package-json value="$PROJECT_DIR$/projects/ngx-meta/example-apps/apps/v18/package.json" />
-        <command value="run" />
-        <scripts>
-          <script value="ng" />
-        </scripts>
-        <arguments value="cache clean" />
+        <command value="exec" />
+        <arguments value="ng cache clean" />
         <node-interpreter value="project" />
         <envs />
       </option>
diff --git a/.idea/runConfigurations/ngx_meta_example_apps_v18__build___serve.xml b/.idea/runConfigurations/ngx_meta_example_apps_v18__build___serve.xml
index 82687cd2..bb245050 100644
--- a/.idea/runConfigurations/ngx_meta_example_apps_v18__build___serve.xml
+++ b/.idea/runConfigurations/ngx_meta_example_apps_v18__build___serve.xml
@@ -18,11 +18,8 @@
       </option>
       <option name="NpmBeforeRunTask" enabled="true">
         <package-json value="$PROJECT_DIR$/projects/ngx-meta/example-apps/apps/v18/package.json" />
-        <command value="run" />
-        <scripts>
-          <script value="ng" />
-        </scripts>
-        <arguments value="cache clean" />
+        <command value="exec" />
+        <arguments value="ng cache clean" />
         <node-interpreter value="project" />
         <envs />
       </option>
diff --git a/package.json b/package.json
index 76b4a391..aaa035c9 100644
--- a/package.json
+++ b/package.json
@@ -1,48 +1,47 @@
 {
   "name": "@davidlj95/ngx",
   "version": "0.0.0",
+  "private": true,
   "scripts": {
-    "ng": "ng",
-    "start": "ng serve",
     "build": "ng build && ./postbuild.sh",
-    "watch": "ng build --watch --configuration development",
-    "test:unit": "pnpm run '/^test:unit:\\w*$/'",
-    "test:unit:coverage": "pnpm run '/^test:unit:\\w*:coverage$/'",
-    "test:unit:libs": "ng test --no-watch",
-    "test:unit:libs:coverage": "pnpm run test:unit:libs --code-coverage",
-    "test:unit:schematics": "jest",
-    "test:unit:schematics:coverage": "pnpm run test:unit:schematics --collect-coverage",
+    "commit": "pnpx @commitlint/prompt-cli",
+    "commitlint-edit-msg": "commitlint --verbose --edit",
+    "commitlint-last": "commitlint --last --verbose",
+    "coverage:move-to-nyc-output": "rm -rf .nyc_output && mkdir .nyc_output && cp -f $(find coverage -type f -name '*.json') .nyc_output",
+    "coverage:report:all": "pnpm run coverage:move-to-nyc-output && nyc report --reporter lcov --report-dir coverage",
+    "format": "prettier --ignore-unknown --write",
+    "format-all": "npm run format -- .",
+    "format-check": "prettier --check",
+    "format-check-all": "npm run format-check -- .",
+    "instrument-for-coverage": "./instrument-for-coverage.sh",
     "lint": "pnpm run '/^lint:[\\w-]+$/'",
     "lint:code": "pnpm run lint:code:raw .",
     "lint:code:raw": "eslint --max-warnings 0",
     "lint:commit-message": "pnpm run commitlint-edit-msg",
     "lint:gh-actions": "./actionlint.sh",
-    "ngx-meta:test": "ng test ngx-meta",
+    "ngx-meta:api-documenter": "api-documenter markdown -i ./projects/ngx-meta/api-extractor -o ./projects/ngx-meta/docs/content/api",
+    "ngx-meta:api-extractor": "api-extractor run -c ./projects/ngx-meta/src/api-extractor.json",
+    "ngx-meta:api-extractor:local": "pnpm run ngx-meta:tsc:lib && pnpm run ngx-meta:api-extractor --local",
     "ngx-meta:lint": "ng lint ngx-meta",
+    "ngx-meta:test": "ng test ngx-meta",
     "ngx-meta:tsc": "pnpm run '/^ngx-meta:tsc:.*/'",
     "ngx-meta:tsc:lib": "tsc -p ./projects/ngx-meta/src/tsconfig.lib.json --listEmittedFiles",
     "ngx-meta:tsc:spec": "tsc -p ./projects/ngx-meta/src/tsconfig.spec.json --listEmittedFiles",
-    "ngx-meta:api-extractor": "api-extractor run -c ./projects/ngx-meta/src/api-extractor.json",
-    "ngx-meta:api-extractor:local": "pnpm run ngx-meta:tsc:lib && pnpm run ngx-meta:api-extractor --local",
-    "ngx-meta:api-documenter": "api-documenter markdown -i ./projects/ngx-meta/api-extractor -o ./projects/ngx-meta/docs/content/api",
-    "coverage:report:all": "pnpm run coverage:move-to-nyc-output && nyc report --reporter lcov --report-dir coverage",
-    "coverage:move-to-nyc-output": "rm -rf .nyc_output && mkdir .nyc_output && cp -f $(find coverage -type f -name '*.json') .nyc_output",
-    "format-check": "prettier --check",
-    "format-check-all": "npm run format-check -- .",
-    "format": "prettier --ignore-unknown --write",
-    "format-all": "npm run format -- .",
     "prepare": "husky",
-    "commitlint-edit-msg": "commitlint --verbose --edit",
-    "commitlint-last": "commitlint --last --verbose",
-    "cache-clean": "ng cache clean",
-    "commit": "pnpx @commitlint/prompt-cli",
-    "validate-codecov-yml": "curl -X POST --data-binary @codecov.yml https://codecov.io/validate",
-    "instrument-for-coverage": "./instrument-for-coverage.sh",
+    "semantic-release:local": "./semantic-release-local.sh",
+    "start": "ng serve",
+    "test:unit": "pnpm run '/^test:unit:\\w*$/'",
+    "test:unit:coverage": "pnpm run '/^test:unit:\\w*:coverage$/'",
+    "test:unit:libs": "ng test --no-watch",
+    "test:unit:libs:coverage": "pnpm run test:unit:libs --code-coverage",
+    "test:unit:schematics": "jest",
+    "test:unit:schematics:coverage": "pnpm run test:unit:schematics --collect-coverage",
     "update": "ng update @angular/cli @angular/core @angular-eslint/schematics",
-    "semantic-release:local": "./semantic-release-local.sh"
+    "validate": "pnpm run '/^validate:.*/'",
+    "validate:codecov-yml": "curl -X POST --data-binary @codecov.yml https://codecov.io/validate",
+    "validate:renovate-config": "pnpm --package renovate dlx renovate-config-validator",
+    "watch": "ng build --watch --configuration development"
   },
-  "private": true,
-  "packageManager": "pnpm@9.12.3",
   "dependencies": {
     "@angular/animations": "18.2.10",
     "@angular/common": "18.2.10",
@@ -104,5 +103,6 @@
     "semantic-release": "24.2.0",
     "ts-jest": "29.2.5",
     "typescript": "5.4.5"
-  }
+  },
+  "packageManager": "pnpm@9.12.3"
 }
diff --git a/projects/ngx-meta/bundle-size/package.json b/projects/ngx-meta/bundle-size/package.json
index 789e3b60..0f6435e5 100644
--- a/projects/ngx-meta/bundle-size/package.json
+++ b/projects/ngx-meta/bundle-size/package.json
@@ -1,14 +1,14 @@
 {
   "name": "@ngx-meta/bundle-size",
   "version": "0.0.0",
+  "private": true,
   "description": "ngx-meta bundle size analysis infra",
   "scripts": {
     "analyze": "./analyze.sh",
     "report": "./report.sh"
   },
-  "packageManager": "pnpm@9.12.3",
-  "private": true,
   "devDependencies": {
     "source-map-explorer": "2.5.3"
-  }
+  },
+  "packageManager": "pnpm@9.12.3"
 }
diff --git a/projects/ngx-meta/e2e/package.json b/projects/ngx-meta/e2e/package.json
index acd5bb67..83061f9b 100644
--- a/projects/ngx-meta/e2e/package.json
+++ b/projects/ngx-meta/e2e/package.json
@@ -1,14 +1,13 @@
 {
   "name": "@ngx-meta/cypress",
   "version": "0.0.0",
+  "private": true,
   "description": "ngx-meta E2E testing infra",
   "scripts": {
     "cypress:open": "cypress open",
     "cypress:run": "cypress run",
     "test": "./start-server-and-test.sh"
   },
-  "packageManager": "pnpm@9.12.3",
-  "private": true,
   "devDependencies": {
     "@cypress/code-coverage": "3.13.5",
     "@istanbuljs/load-nyc-config": "1.1.0",
@@ -17,5 +16,6 @@
     "start-server-and-test": "2.0.8",
     "tslib": "2.7.0",
     "typescript": "5.5.3"
-  }
+  },
+  "packageManager": "pnpm@9.12.3"
 }
diff --git a/projects/ngx-meta/example-apps/package.json b/projects/ngx-meta/example-apps/package.json
index e1280183..000f1536 100644
--- a/projects/ngx-meta/example-apps/package.json
+++ b/projects/ngx-meta/example-apps/package.json
@@ -1,15 +1,14 @@
 {
   "name": "@ngx-meta/example-apps",
   "version": "0.0.0",
+  "private": true,
   "description": "ngx-meta example apps infra",
+  "type": "module",
   "scripts": {
     "build": "tsc",
-    "watch": "tsc --watch",
-    "create-example-app": "node dist/create-example-app.js"
+    "create-example-app": "node dist/create-example-app.js",
+    "watch": "tsc --watch"
   },
-  "packageManager": "pnpm@9.12.3",
-  "private": true,
-  "type": "module",
   "devDependencies": {
     "@types/node": "22.8.7",
     "@types/semver": "7.5.8",
@@ -17,5 +16,6 @@
     "semver": "7.6.3",
     "ts-morph": "24.0.0",
     "typescript": "5.5.3"
-  }
+  },
+  "packageManager": "pnpm@9.12.3"
 }
diff --git a/projects/ngx-meta/schematics/package.json b/projects/ngx-meta/schematics/package.json
index 7f43490b..46ec5446 100644
--- a/projects/ngx-meta/schematics/package.json
+++ b/projects/ngx-meta/schematics/package.json
@@ -2,10 +2,10 @@
   "name": "@ngx-meta/schematics",
   "version": "0.0.0",
   "description": "ngx-meta schematics infra",
-  "packageManager": "pnpm@9.12.3",
   "scripts": {
     "build": "tsc -p tsconfig.schematics.json",
     "postbuild": "rsync -R **/schema.json collection.json ../dist/schematics",
     "test": "jest"
-  }
+  },
+  "packageManager": "pnpm@9.12.3"
 }
diff --git a/projects/ngx-meta/src/package.json b/projects/ngx-meta/src/package.json
index 7c52f258..6d90cf39 100644
--- a/projects/ngx-meta/src/package.json
+++ b/projects/ngx-meta/src/package.json
@@ -21,11 +21,18 @@
     "angular universal"
   ],
   "homepage": "https://ngx-meta.dev",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/davidlj95/ngx.git",
+    "directory": "projects/ngx-meta/src"
+  },
   "license": "MIT",
   "author": {
     "name": "David LJ",
     "url": "https://davidlj95.com"
   },
+  "sideEffects": false,
+  "scripts": {},
   "dependencies": {
     "tslib": "^2.3.0"
   },
@@ -39,16 +46,9 @@
       "optional": true
     }
   },
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/davidlj95/ngx.git",
-    "directory": "projects/ngx-meta/src"
-  },
-  "scripts": {},
   "publishConfig": {
     "access": "public",
     "provenance": true
   },
-  "sideEffects": false,
   "schematics": "./schematics/collection.json"
 }