Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for number before adding px to styles #936

Merged
merged 1 commit into from
Apr 26, 2021
Merged

check for number before adding px to styles #936

merged 1 commit into from
Apr 26, 2021

Conversation

lukesmurray
Copy link
Contributor

@lukesmurray lukesmurray commented Mar 30, 2021 •
edited
Loading

Fix for #930. I moved settings[iframeId][style] into a var styleValue to avoid repeating the accessor over and over again.

@davidjbradshaw davidjbradshaw merged commit 3f84a35 into davidjbradshaw:master Apr 26, 2021
@davidjbradshaw
Copy link
Owner

Released as v4.3.2.

Sorry for the long delay, I crashed my bike and have spent the last couple of months recovering

@lukesmurray
Copy link
Contributor Author

lukesmurray commented Apr 26, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukesmurray @davidjbradshaw