Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second polyfill for Array.forEach #555

Merged
merged 2 commits into from
Jan 21, 2018
Merged

Remove second polyfill for Array.forEach #555

merged 2 commits into from
Jan 21, 2018

Conversation

bitcloud
Copy link
Contributor

There are two polyfills for Array.forEach.

The second one seems to be obsolete so I removed it.

if (!Array.prototype.forEach) {

And I made the project a bit more self contained by installing grunt-cli as devDependency. No need for a global grunt-cli anymore ;-)
(sorry for putting them in one PR)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.106% when pulling a743c9f on bitcloud:polyfill into 2b2df4b on davidjbradshaw:master.

Copy link
Owner

@davidjbradshaw davidjbradshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@davidjbradshaw davidjbradshaw merged commit b591c20 into davidjbradshaw:master Jan 21, 2018
@davidjbradshaw
Copy link
Owner

Release as v3.5.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants