Fix incremental compiler not being able to find JDK classes when compiler macros with Java 11, close #502 #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iler macros with Java 11, close #502 Motivation: Jigsaw has changed the behavior of ClassLoaders. For some reason, ScalaCompilerLoader with a null parent is able to find JDK classes on Java 8 but not on Java 11. Modification: Make the parent the root loader. Result: We can compile macros with Java 11.
HyukjinKwon
pushed a commit
to apache/spark
that referenced
this pull request
Jun 8, 2022
### What changes were proposed in this pull request? This pr aims upgrade scala-maven-plugin to 4.6.2 ### Why are the changes needed? This version brings some bug fix related to `Incremental compile`, although it seems that Spark has not encountered these issue: - [Fix incremental compiler not being able to find JDK classes when compiler macros with Java 11, close #502](davidB/scala-maven-plugin#608) - [Fix incremental compilation on Java 11+, close #600](davidB/scala-maven-plugin#609) all changes as follows: - davidB/scala-maven-plugin@4.6.1...4.6.2 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions Closes #36800 from LuciferYang/scala-maven-plugin-462. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Jigsaw has changed the behavior of ClassLoaders.
For some reason, ScalaCompilerLoader with a null parent is able to find JDK classes on Java 8 but not on Java 11.
Modification:
Make the parent the root loader.
Result:
We can compile macros with Java 11.