Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: A.J. Stein <[email protected]>
  • Loading branch information
david-waltermire and aj-stein-gsa authored Nov 9, 2024
1 parent 9e3f626 commit 0ead761
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ The following are some guidelines to consider when performing code reviews.
- Tone
- Do ask open-ended questions and avoid making opinionated statements.
- Do keep feedback positive. Consider the effort the author spent writing the PR. Celebrate good work.
- Do differentiate between nits and suggestions vs blocking feedback. Limit nits.
- Do differentiate between nits and suggestions vs blocking feedback. Limit nits. Use [Conventional Comments](https://conventionalcomments.org) to the greatest extent possible.
- Do consider how your feedback could be addressed by follow-on work. Consider opening new issues for less significant concerns.
- Unit Testing
- Do consider the coverage of test cases. Do the unit tests cover major code paths and error conditions?
Expand Down

0 comments on commit 0ead761

Please sign in to comment.