Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsconfig parser does not support Node.js-style resolution of the extends field #72

Closed
bjoluc opened this issue Sep 6, 2023 · 3 comments · Fixed by #73
Closed

Tsconfig parser does not support Node.js-style resolution of the extends field #72

bjoluc opened this issue Sep 6, 2023 · 3 comments · Fixed by #73

Comments

@bjoluc
Copy link
Contributor

bjoluc commented Sep 6, 2023

#65 removed support for Node.js-style resolution of the tsconfig extends field – something that TypeScript can do. Implementing this from-scratch is not entirely trivial, but get-tsconfig has it all. @davestewart Since you decided against get-tsconfig, I'm not sure if there's a reason not to use it in this project? If not, I'm happy to submit a PR (I'm desperately depending on module resolution in extends 🥲). Just drop me a thumbs-up reaction here if get-tsconfig would also work.

@davestewart
Copy link
Owner

Ah! Wasn't aware there was a difference. That was removed for other reasons. If this other package does it right then it's a candidate.

Let me take a look later today (actually have some free time as I'm on holiday) and report back 👍

@bjoluc
Copy link
Contributor Author

bjoluc commented Sep 6, 2023

Thanks for the super-fast reply! For the reference and maybe to save you some time, here's how TS resolves extends paths and here's how get-tsconfig does it.

EDIT: TS 5 allows extends to be an array, so now is the time to rely on other projects to add support for this 😄

@davestewart
Copy link
Owner

The README for the project looks just the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants