You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should avoid null if the property is optional and use the ? instead.
exportinterfaceIScatterConfigextendsBaseVisConfig{type: ESupportedPlotlyVis.SCATTER;// Numerical columns selected for x and y axis. If 2 are selected, a normal scatter plot is shown. If more than 2 are selected, a SPLOM is shown.numColumnsSelected: ColumnInfo[];// This attribute splits the data into multiple scatter plots based on the selected column.facets?: ColumnInfo;// This attribute can be used to directly control which subplots should be shown.subplots?: {xColumn: ColumnInfo;yColumn: ColumnInfo;title: string}[];color?: ColumnInfo;numColorScaleType: ENumericalColorScaleType;shape?: ColumnInfo;dragMode: EScatterSelectSettings;alphaSliderVal: number;showLabels: ELabelingOptions;showLabelLimit?: number;regressionLineOptions?: IRegressionLineOptions;showLegend?: boolean;labelColumns?: ColumnInfo[];}
By making the facets, color, and shape optional, we must also change the default config by removing the properties with null values:
Currently, we are using different ways of
null
andundefined
aka optional property with?
. Here is an example of the scatterplot config:visyn_core/src/vis/scatter/interfaces.ts
Lines 3 to 21 in f67d209
We should avoid
null
if the property is optional and use the?
instead.By making the
facets
,color
, andshape
optional, we must also change the default config by removing the properties withnull
values:Changing this will change the application behavior, hence, it must be tested carefully.
This also applies to other configuration from visualization types.
The text was updated successfully, but these errors were encountered: