Skip to content

Commit

Permalink
Release 15.0.1 (#750)
Browse files Browse the repository at this point in the history
* adding custom data to basic bar charts

* fixing context selection bug

* more bug fixes

* Refactor multi selection adapter

- Add optional `diffSubtypes` to `IMultiSelectionAdapter`
- Remove `ReprovisynMultiSelectionAdapter`
- Add generics to `MultiSelectionAdapter`
- Comment functions of `MultiSelectionAdapter`

* Replace `PromiseLike` with `Promise` + async/await

See also https://masteringjs.io/tutorials/fundamentals/promise-resolve

* Replace `() => IContext` with `IContext`

Unecessary convoluted call

* Remove `waitForIt` promise from selection adapter

- Add and refactor return types `Promise<any>` to `Promise<void>`
- Switch to async/await where possible
- await `removeDynamicColumns` before `addDynamicColumns` -> previously it was not waited for the removal

* Add unit tests for SelectionAdapter

* adding parameters check on use effect

* removing outdated todo

* Update context inside selection adapter

* fixing default params value

* builds

* fixing bar selection

* making bar click removal work

* code improvements

* fixing uncontrolled error

* removing zooming on bar charts

* adding promise to fix typing

* pr suggestions/cleanup

* prepare next development version 15.0.1-SNAPSHOT

* Added build-storybook to build script (#733)

* Added build-storybook to build script

* Add tdp_core/dist alias to the storybook webpack config

* updated version of storybook (#736)

Co-authored-by: Moritz Heckmann <[email protected]>

Co-authored-by: dvmoritzschoefl <[email protected]>
Co-authored-by: Moritz Heckmann <[email protected]>

* Fix eslint for AggregateTypeSelected

Probably a missing type cast in PR #729

* Remove await `this.built` in `withoutTracking()`

Waiting for `this.built` will never resolve/terminate and show an infite loading icon.

Reason: `this.built` is created with `build()` in line 355 and it is only resolved after the `build()` call is complete.

With the changes to the selection adapter the `this.selectionAdapter.selectionChanged` now returns a valid promise. Previously, `context.add()` did not return it's promise (see 919cfb2#diff-f0f07e4a6ac30a813315b152545245d4cf26830e01b701f3e82ff7b5c22363a7R18). Now, we are waiting until all dynamic columns are added. The circle closes when we add the columns which calls `withoutTracking()` which in-turn is waiting for the resolved `this.built` promise.

As far as I can see, we always call `withoutTracking` on a built/resolved ranking view. In the other places (line 377 and 400) we have a dedicated `await this.built;` before triggering changes to dynamic columns.

In my tests adding and removing columns via score and selection adapter worked as before. I also tested reloading the page and checked the result of the session. In all cases it looks the same as before.

* use `useRef` instead of `useSyncedRef`

* Add Storybook stories for custom buttons (#708)

* create first storybook for button styles

* add story for single button

* change background

* linting

* fix background

* add additional kind of buttons

* typing

* add functions for buttons into stories

* started chaning source of button

* finish Button storybook docu

* linting problems

* linting

* styling of code

* change style to UI

* add comments

* Added build-storybook to build script

* Add tdp_core/dist alias to the storybook webpack config

* added outline buttons, adjusted layout to not contain margin inside a story, added link to styleguide

Co-authored-by: Michael Puehringer <[email protected]>
Co-authored-by: Moritz Heckmann <[email protected]>

* added cypress run script to package json (#738)

Co-authored-by: Moritz Heckmann <[email protected]>

* Add exception handler middleware (#723)

* Add exception handler middleware

* Extract default logging config and set it on server startup

Co-authored-by: dvtschachinger <[email protected]>

* address PR comments

* adding description to axis labels (#744)

* Add NODE_OPTIONS=--max_old_space_size=4096  to storybook scripts (#746)

* Add NODE_OPTIONS=--max_old_space_size=4096  to storybook scripts

* Update build script to include storybook:build

* Update cache key

* Fix `ARankingView` typings of `rebuild` and `reloadData` (#749)

* prepare release 15.0.1

Co-authored-by: dvzacharycutler <[email protected]>
Co-authored-by: Holger Stitz <[email protected]>
Co-authored-by: oltionchampari <[email protected]>
Co-authored-by: Michael Pühringer <[email protected]>
Co-authored-by: dvmoritzschoefl <[email protected]>
Co-authored-by: Moritz Heckmann <[email protected]>
Co-authored-by: Christian Bors <[email protected]>
Co-authored-by: dvflorianengertsberger <[email protected]>
Co-authored-by: Michael Puehringer <[email protected]>
Co-authored-by: dvtschachinger <[email protected]>
Co-authored-by: Zach Cutler <[email protected]>
  • Loading branch information
12 people authored Jul 1, 2022
1 parent 829cdc6 commit 93527f7
Show file tree
Hide file tree
Showing 95 changed files with 2,486 additions and 850 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
node -v
npm -v
- restore_cache:
key: deps1-{{ .Branch }}-{{ checksum "package.json" }}
key: deps2-{{ .Branch }}-{{ checksum "package.json" }}
- run:
name: Install npm dependencies
command: npm install
Expand All @@ -101,7 +101,7 @@ jobs:
command: |
(grep -l '._resolved.: .\(git[^:]*\|bitbucket\):' ./node_modules/*/package.json || true) | xargs -r dirname | xargs -r rm -rf
- save_cache:
key: deps1-{{ .Branch }}-{{ checksum "package.json" }}
key: deps2-{{ .Branch }}-{{ checksum "package.json" }}
paths: ./node_modules
- run:
name: Install npm dependencies from git repositories (always get latest commit)
Expand Down
17 changes: 14 additions & 3 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,24 @@
const path = require('path');

module.exports = {
"stories": [
stories: [
"../src/**/*.stories.mdx",
"../src/**/*.stories.@(js|jsx|ts|tsx)"
],
"addons": [
addons: [
"@storybook/addon-links",
"@storybook/addon-essentials",
"@storybook/addon-interactions",
"@storybook/preset-scss"
],
"framework": "@storybook/react"
framework: "@storybook/react",
webpackFinal: async (config) => {
// Add tdp_core/dist as alias, as we have scss/code imports like tdp_core/dist/assets/...
// These can only be resolved in a workspace currently, and not in the standalone repo.
config.resolve.alias = {
...(config.resolve.alias || {}),
'tdp_core/dist': path.resolve(__dirname, '../', 'dist')
};
return config;
},
}
2 changes: 1 addition & 1 deletion dist/base/rest.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 29 additions & 9 deletions dist/lineup/ARankingView.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/lineup/ARankingView.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 35 additions & 12 deletions dist/lineup/ARankingView.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/lineup/ARankingView.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lineup/Ranking.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 93527f7

Please sign in to comment.