Bug Fix #36
Merged
Bug Fix #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype of parameter is a function in the passed context.
|
Nice catch! |
|
Published as https://github.com/datavis-tech/json-templates/releases/tag/v4.1.0 I realize there's no documentation in the README for this new feature. Is that something you'd be willing to take on @pranavwani ? New issue for that is here #37 . Thanks! |
curran
reviewed
Oct 5, 2020
| it('should compute template with function with multiple inner parameters', () => { | ||
| const template = parse(JSON.stringify({ username: "{{username}}", password: "{{password}}" })); | ||
| assert.deepEqual(template.parameters, [{ key: 'username' }, { key: 'password' }]); | ||
| assert.equal(template({ username: () => ("John"), password: () => ("John") }), '{"username":"John","password":"John"}'); |
There was a problem hiding this comment.
@pranavwani I'm confused as to why template() is returning a string here. I would have expected it to return the object itself. Also, this test could be improved by using a different value for password.
There was a problem hiding this comment.
Yeah, actually trying to passing JSON string to the template parser. It's similar to string with multiple arguments.
I think comment should be appropriate.
|
@curran I'll add the doc for it. Thanks 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content returning without replacing the parameter's value while the type of parameter is a function in the passed context.