Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use $ #31

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Add support to use $ #31

merged 1 commit into from
Sep 15, 2020

Conversation

pranavwani
Copy link

Can use $ as: {{$ip}}

Can use `$` as: "{{$ip}}"
@pranavwani pranavwani changed the title Add support to use $ Add support to use **$** Aug 10, 2020
@pranavwani pranavwani changed the title Add support to use **$** Add support to use $ Aug 10, 2020
@curran
Copy link
Member

curran commented Sep 15, 2020

@pranavwani Apologies, I'm just noticing this now! Would you be able to please add a test that covers this change? Thanks!

@curran
Copy link
Member

curran commented Sep 15, 2020

This is good. I will add the test. Thanks for this!

@curran curran merged commit 3587af2 into datavis-tech:master Sep 15, 2020
@pranavwani
Copy link
Author

@curran Thanks 👍

@pranavwani
Copy link
Author

pranavwani commented Sep 16, 2020

@pranavwani Apologies, I'm just noticing this now! Would you be able to please add a test that covers this change? Thanks!

Sorry, about that. Just seen that the test case is not added. Thanks for adding it

@curran
Copy link
Member

curran commented Sep 16, 2020

My pleasure! Thanks for this contribution. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants