Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transpile to ES5 before publishing npm module by calling build script. #25

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Transpile to ES5 before publishing npm module by calling build script. #25

merged 1 commit into from
Sep 11, 2018

Conversation

BrerBear
Copy link
Contributor

Closes #24

curran
curran approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here!

package.json
@@ -1,9 +1,10 @@
{
"name": "json-templates",
"version": "2.2.0",
"version": "2.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will undo this and let the NPM tool do this as part of the release process.

rollup.config.js
input: 'index.js',
output: {
format: 'umd',
name: 'JSON templates',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is used as a global variable name, so I'll change this to something without spaces.

@curran curran merged commit bc8fc20 into datavis-tech:master Sep 11, 2018
@curran
Copy link
Member

curran commented Sep 11, 2018

@BrerBear Released as https://github.com/datavis-tech/json-templates/releases/tag/v2.3.0

Can you please verify that it works in your desired build environment? Thanks!

@BrerBear
Copy link
Contributor Author

react-scripts build system works fine with this update. Thank you!

@BrerBear BrerBear deleted the transpile branch September 11, 2018 16:52
@curran
Copy link
Member

curran commented Sep 12, 2018

Excellent! Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curran curran curran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrerBear @curran