Enable inner parameters in a string #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curran
approved these changes
Oct 6, 2016
| @@ -4,6 +4,7 @@ | |||
| // By Curran Kelleher | |||
| // September 2016 | |||
|
|
|||
| const regex = new RegExp(/{{(\w+)(:?(.*))+}}/i); | |||
There was a problem hiding this comment.
Sweet change! Did you come up with that regex yourself? If not I'd like to cite the source.
| && | ||
| (str.substr(str.length - 2, 2) === "}}") | ||
| ); | ||
| return regex.test(str); |
| @@ -58,13 +58,25 @@ describe("json-template", function() { | |||
| assert.equal(template({ unknownParam: "baz" }), "bar:baz"); | |||
| }); | |||
|
|
|||
| it("should compute template for a string with inner parameter", function() { | |||
There was a problem hiding this comment.
Nice, thanks for adding these tests.
|
Just released this in https://github.com/curran/json-templates/releases/tag/v1.1.0 and on NPM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add inner parameter support.
Here is an example:
Note: To avoid calling
str.match(regex)twice, I updated the prototype of the function namedParameterto accept the result of the match call instead of a string.