Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] UI: the font family of gravitino title text in productiton mode does not match with dev mode #3386

Closed
ch3yne opened this issue May 14, 2024 · 0 comments · Fixed by #3387
Closed

[Bug report] UI: the font family of gravitino title text in productiton mode does not match with dev mode #3386

ch3yne opened this issue May 14, 2024 · 0 comments · Fixed by #3387
Assignees
@ch3yne
Labels
bug Something isn't working

Comments

@ch3yne
Copy link
Contributor

ch3yne commented May 14, 2024

Version

main branch

Describe what's wrong

The font family of gravitino title text in productiton mode does not match with dev mode.

Error message and/or stacktrace

N/A

How to reproduce

replace to the true fonts.

Additional context

No response
@ch3yne ch3yne added the bug Something isn't working label May 14, 2024
@ch3yne ch3yne self-assigned this May 14, 2024
@ch3yne ch3yne mentioned this issue May 14, 2024
Merged
LauraXia123 pushed a commit that referenced this issue May 15, 2024
@ch3yne
[#3386] fix(web): fix font family of the gravitino title (#3387)
f80aed9 
### What changes were proposed in this pull request?

Fix font family of the Gravitino title.

Before:

<img width="185" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/2e7b7b5b-9482-4343-b9ad-493aa7934014">


After:

<img width="171" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/00b6365e-3766-4c33-898a-e84dcb5b21fd">


### Why are the changes needed?

Fix: #3386

### Does this PR introduce _any_ user-facing change?

Change to the true font family.

### How was this patch tested?

N/A
github-actions bot pushed a commit that referenced this issue May 15, 2024
@ch3yne @web-flow
[#3386] fix(web): fix font family of the gravitino title (#3387)
e45a961 
### What changes were proposed in this pull request?

Fix font family of the Gravitino title.

Before:

<img width="185" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/2e7b7b5b-9482-4343-b9ad-493aa7934014">


After:

<img width="171" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/00b6365e-3766-4c33-898a-e84dcb5b21fd">


### Why are the changes needed?

Fix: #3386

### Does this PR introduce _any_ user-facing change?

Change to the true font family.

### How was this patch tested?

N/A
@jerryshao jerryshao mentioned this issue May 15, 2024
Merged
LauraXia123 pushed a commit that referenced this issue May 15, 2024
@jerryshao @ch3yne
[#3386] fix(web): fix font family of the gravitino title (#3397)
e81fcd9 
### What changes were proposed in this pull request?

Fix font family of the Gravitino title.

Before:

<img width="185" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/2e7b7b5b-9482-4343-b9ad-493aa7934014">


After:

<img width="171" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/00b6365e-3766-4c33-898a-e84dcb5b21fd">


### Why are the changes needed?

Fix: #3386

### Does this PR introduce _any_ user-facing change?

Change to the true font family.

### How was this patch tested?

N/A

Co-authored-by: CHEYNE <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@ch3yne @diqiu50
[apache#3386] fix(web): fix font family of the gravitino title (apach…
8299192 
…e#3387)

### What changes were proposed in this pull request?

Fix font family of the Gravitino title.

Before:

<img width="185" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/2e7b7b5b-9482-4343-b9ad-493aa7934014">


After:

<img width="171" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/00b6365e-3766-4c33-898a-e84dcb5b21fd">


### Why are the changes needed?

Fix: apache#3386

### Does this PR introduce _any_ user-facing change?

Change to the true font family.

### How was this patch tested?

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch3yne ch3yne

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3386] fix(web): fix font family of the gravitino title ch3yne/gravitino
2 participants
@LauraXia123 @ch3yne