Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Adding a new Apache Kafka catalog works but times out listing topics #3249

Closed
justinmclean opened this issue May 2, 2024 · 2 comments · Fixed by #3417
Closed

[Improvement] Adding a new Apache Kafka catalog works but times out listing topics #3249

justinmclean opened this issue May 2, 2024 · 2 comments · Fixed by #3417
Assignees
@mchades
Labels
improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

If you add a Kafka catalog using the URL of a non-running Kafka server in a catalog it be added with no error. It will timeout after 30 seconds (or so) of trying to list the topics when you click on the default "sechma".

How should we improve?

  1. Verify the URL when it is entered.
  2. Shorten the timeout.
  3. Improve the error message displayed to the user.
@justinmclean justinmclean added the improvement Improvements on everything label May 2, 2024
@jerryshao
Copy link
Contributor

@mchades would you please check and try to improve this issue.

@justinmclean
Copy link
Member Author

@mchades ignore my last comment - this is still an issue.

@mchades mchades mentioned this issue May 16, 2024
Merged
jerryshao pushed a commit that referenced this issue May 17, 2024
@mchades
[#3249] improvement(kafka-catalog): clarify error message and shorten…
ccebb18 
… timeout (#3417)

### What changes were proposed in this pull request?

 -  Transmit the real reason for the error to the user
 - shorten timeout from 60s to 15s
 - add thread info to the log
 - add default timeout config to the conf file

### Why are the changes needed?

Fix: #3249 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

test added
github-actions bot pushed a commit that referenced this issue May 17, 2024
@mchades @web-flow
[#3249] improvement(kafka-catalog): clarify error message and shorten…
53d59a6 
… timeout (#3417)

### What changes were proposed in this pull request?

 -  Transmit the real reason for the error to the user
 - shorten timeout from 60s to 15s
 - add thread info to the log
 - add default timeout config to the conf file

### Why are the changes needed?

Fix: #3249 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

test added
@jerryshao jerryshao mentioned this issue May 17, 2024
Merged
mchades added a commit that referenced this issue May 17, 2024
@jerryshao @mchades
[#3249] improvement(kafka-catalog): clarify error message and shorten…
09caf0a 
… timeout (#3421)

### What changes were proposed in this pull request?

 -  Transmit the real reason for the error to the user
 - shorten timeout from 60s to 15s
 - add thread info to the log
 - add default timeout config to the conf file

### Why are the changes needed?

Fix: #3249 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

test added

Co-authored-by: mchades <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@mchades @diqiu50
[apache#3249] improvement(kafka-catalog): clarify error message and s…
ecb1dac 
…horten timeout (apache#3417)

### What changes were proposed in this pull request?

 -  Transmit the real reason for the error to the user
 - shorten timeout from 60s to 15s
 - add thread info to the log
 - add default timeout config to the conf file

### Why are the changes needed?

Fix: apache#3249 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

test added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchades mchades

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3249] improvement(kafka-catalog): clarify error message and shorten timeout mchades/gravitino
3 participants
@justinmclean @jerryshao @mchades